-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add global-rate-limit feature #11897
Comments
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This feature has been removed on purpose as we are not able to maintain it any longer. As it's not part of NGINX itself, it requires some modifications and dependencies (see removal PR) like Lua. We'd like to reduce the complexity of the project and therefore also get rid of features that are not directly connected to the Ingress API and are - normally - handled by fronting load balancers or network itself. As I already commented on the PR, there are setups like yours that do not have a fronting load balancer. In our opinion this scenario can not be considered in Ingress NGINX as we'd like to focus on routing and balancing traffic inside the cluster and therefore remove features that are - again, normally - handled by other parts of a cloud native infrastructure. |
No LUA either?! |
Lua itself is still being used, but we removed the possibility to define your own Lua plugins. The Global Rate Limiting feature was a built-in plugin not affected by this Lua plugin removal, but still maintained through a 3rd party library. As we internally discussed the scope of this project, and therefore also the efforts we can bring up for it, we decided that a feature like the Global Rate Limiting one should rather be handled by a fronting load balancer or comparable network infrastructure but not by Ingress NGINX. |
We use the global-rate-limit feature intensively
For example, on platforms not supporting native load balancing we use it for rate limiting reverse proxy using multiple pods.
Is it possible to re-add this feature? This feature is removed by #11851
The text was updated successfully, but these errors were encountered: