Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add global-rate-limit feature #11897

Closed
ScriptGod1337 opened this issue Aug 28, 2024 · 4 comments
Closed

Re-add global-rate-limit feature #11897

ScriptGod1337 opened this issue Aug 28, 2024 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ScriptGod1337
Copy link

We use the global-rate-limit feature intensively
For example, on platforms not supporting native load balancing we use it for rate limiting reverse proxy using multiple pods.

Is it possible to re-add this feature? This feature is removed by #11851

@ScriptGod1337 ScriptGod1337 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 28, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Aug 28, 2024

This feature has been removed on purpose as we are not able to maintain it any longer. As it's not part of NGINX itself, it requires some modifications and dependencies (see removal PR) like Lua. We'd like to reduce the complexity of the project and therefore also get rid of features that are not directly connected to the Ingress API and are - normally - handled by fronting load balancers or network itself.

As I already commented on the PR, there are setups like yours that do not have a fronting load balancer. In our opinion this scenario can not be considered in Ingress NGINX as we'd like to focus on routing and balancing traffic inside the cluster and therefore remove features that are - again, normally - handled by other parts of a cloud native infrastructure.

@Gacko Gacko closed this as completed Aug 28, 2024
@saminou
Copy link

saminou commented Aug 30, 2024

This feature has been removed on purpose as we are not able to maintain it any longer. As it's not part of NGINX itself, it requires some modifications and dependencies (see removal PR) like Lua. We'd like to reduce the complexity of the project and therefore also get rid of features that are not directly connected to the Ingress API and are - normally - handled by fronting load balancers or network itself.

No LUA either?!
Okay so we basically need an openresty-ingress to keep supporting the complex advanced features you obviously don't need/understand thanks to your cloud-nativity.

@Gacko
Copy link
Member

Gacko commented Aug 31, 2024

Lua itself is still being used, but we removed the possibility to define your own Lua plugins. The Global Rate Limiting feature was a built-in plugin not affected by this Lua plugin removal, but still maintained through a 3rd party library.

As we internally discussed the scope of this project, and therefore also the efforts we can bring up for it, we decided that a feature like the Global Rate Limiting one should rather be handled by a fronting load balancer or comparable network infrastructure but not by Ingress NGINX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

4 participants