-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global-rate-limit feature #11851
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8da8f93
to
62ea0a5
Compare
please do not cherry-pick this change :) |
62ea0a5
to
cfda5f8
Compare
global-rate-limit-memcached-host: "memcached.{{ .Release.Namespace }}.svc.kubernetes.local" | ||
global-rate-limit-memcached-port: 11211 | ||
use-gzip: true | ||
asserts: | ||
- equal: | ||
path: data.global-rate-limit-memcached-host | ||
value: memcached.NAMESPACE.svc.kubernetes.local | ||
- equal: | ||
path: data.global-rate-limit-memcached-port | ||
value: "11211" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was meant for testing different value types, not the global-rate-limit
feature itself. Gonna re-add other values.
Any recommendation for people who use ingress-nginx as the fronting load balancer? :) |
I think the infra-provider created LoadBalancers support rate-limiting on most cloud providers. |
Sad fact: vSphere works with MetalLB, so there is no such Load Balancer fronting your cluster. The Load Balancer IP is a virtual IP of a node. Just one example... |
True. But also practical aspect is Metallb/On-premise type engineers will make sophisticated choices like rate-limit or DDOS protection etc on their edge router. |
What this PR does / why we need it:
This PR removes the global-rate-limit feature. On the goal to make ingress-nginx more slim, we need to deprecate features not widely used.
Specifically this feature should be controlled by the fronting Load Balancer and not by ingress-nginx, and it adds some complexity on the code that we may not be able to maintain in future releases
/kind deprecation