You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Though in the file ingress-nginx/internal/ingress/annotations/parser/main.go
We have hardcoded annotation prefix AnnotationsPrefix = "nginx.ingress.kubernetes.io"
Though it can be overridden by annotationsPrefix = flags.String("annotations-prefix", "nginx.ingress.kubernetes.io", Prefix of the ingress annotations.)
IMHO, either the example should change or ingress-nginx should support ingress.kubernetes.io/rewrite-target OOB.
Note #683 and @delacroixe@colemickens comments, I doubt they execute the controller with --annotations-prefix.
What do you guys think?
The text was updated successfully, but these errors were encountered:
@boazj just in case the annotation ingress.kubernetes.io/rewrite-target was created in this repository and landed in the docs giving the impression it was supported by all the ingress controllers.
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST
NGINX Ingress controller version:
0.10.0
What happened:
The Kubernetes documentation of Ingress provide the following example (https://kubernetes.io/docs/concepts/services-networking/ingress/)
and link directly to ingress-nginx documentation (https://github.com/kubernetes/ingress-nginx/blob/master/docs/examples/rewrite/README.md)
Though in the file ingress-nginx/internal/ingress/annotations/parser/main.go
We have hardcoded annotation prefix
AnnotationsPrefix = "nginx.ingress.kubernetes.io"
Though it can be overridden by
annotationsPrefix = flags.String("annotations-prefix", "nginx.ingress.kubernetes.io",
Prefix of the ingress annotations.)
IMHO, either the example should change or ingress-nginx should support
ingress.kubernetes.io/rewrite-target
OOB.Note #683 and @delacroixe @colemickens comments, I doubt they execute the controller with --annotations-prefix.
What do you guys think?
The text was updated successfully, but these errors were encountered: