nginx-specific annotations should say nginx

[thockin]

Example: ingress.kubernetes.io/rewrite-target is not a generic ingress option, and does not work on generic Ingress. That should have been nginx.com/rewrite-target or something.

This is confusing to people who read docs or examples. We should change the controller to support these, and fix all docs to use the new names. Obviously we still have to accept them.

[krallistic]

Other Ingress started to use this annotation as well: traefik/traefik#1723

What seen as the generic ingress? I always thought nginx was that... :)

[thockin]

There is no generic Ingress. If we name annotations like this people assume (reasonably so) that it works everywhere. But it doesn't. I could live with a name like `nonportable.ingress.kubernetes.io/...` or `impl.ingress...` ?

…

On Sun, Oct 1, 2017 at 2:07 AM, krallistic ***@***.***> wrote: Other Ingress started to use this annotation as well: traefik/traefik#1723 <traefik/traefik#1723> What seen as the generic ingress? I always thought nginx was that... :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVDP8WikSemjTSQEM3nmpYzjSpMnBks5sn1ZvgaJpZM4Pms4K> .

[krallistic]

I see.
One thing i like about ingress that they have the potential to (nginx, haproxy, traefik) by having common interface to all of them. route rewriting is imho one of the basic things almost everybody has to do. (But i can see that there a lot of other nginx specific annotations currently)

Maybe something like experimental.ingress... at the beginning. If other implementations dont use that term change to $impl.ingress.... (That way its not a define standard forced upon people, more like see what sticks..)

[thockin]

"experimental" historically meant something else that you don't want to be associated with :)

…

On Sun, Oct 1, 2017 at 11:56 PM, krallistic ***@***.***> wrote: I see. One thing i like about ingress that they have the potential to (nginx, haproxy, traefik) by having common interface to all of them. route rewriting is imho one of the basic things almost everybody has to do. (But i can see that there a lot of other nginx specific annotations currently) Maybe something like experimental.ingress... at the beginning. If other implementations dont use that term change to $impl.ingress.... (That way its not a define standard forced upon people, more like see what sticks..) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVABaGAWBnZZ01JZ-Bb2cAqk7viwPks5soIk5gaJpZM4Pms4K> .

[iamwilhelm]

To people searching for nginx.ingress.kubernetes.io/rewrite-target vs ingress.kubernetes.io/rewrite-target, I found I needed the former for it to work on GCE, and the latter for minikube.