Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaultbackend image in Helm chart is deprecated #8141

Closed
sozercan opened this issue Jan 13, 2022 · 7 comments
Closed

Defaultbackend image in Helm chart is deprecated #8141

sozercan opened this issue Jan 13, 2022 · 7 comments
Assignees
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@sozercan
Copy link

Defaultbackend value in Helm chart uses 1.5 and it is enabled by default
https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml#L733-L738

However, this image got moved to ingress-gce repo a while back
kubernetes/ingress-gce#503
#3156

Looks like Helm values never got updated to point to new image and ingress-nginx now provides default backend functionality unless custom backend is needed (#3126).

Should Helm chart default backend be disabled by default and updated with new image?

@sozercan sozercan added the kind/bug Categorizes issue or PR as related to a bug. label Jan 13, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 13, 2022
@k8s-ci-robot
Copy link
Contributor

@sozercan: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@longwuyuan
Copy link
Contributor

Please explain what problem needs to be solved, in complete detail.

I was able to pull the image just now ;

% docker pull k8s.gcr.io/defaultbackend-amd64:1.5
1.5: Pulling from defaultbackend-amd64
65f4220de95d: Pull complete 
Digest: sha256:4dc5e07c8ca4e23bddb3153737d7b8c556e5fb2f29c4558b7cd6e6df99c512c7
Status: Downloaded newer image for k8s.gcr.io/defaultbackend-amd64:1.5
k8s.gcr.io/defaultbackend-amd64:1.5
[~] 
% docker images | grep -i defaultbackend
k8s.gcr.io/defaultbackend-amd64       1.5       b5af743e5984   3 years ago   5.13MB
[~] 
% 

I assume that if someone wants to use the image in question, they can. But most users would end up using their own images. So the problem to solve is not clear here.

/remove-kind bug

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jan 14, 2022
@strongjz
Copy link
Member

/assign @longwuyuan

@strongjz
Copy link
Member

I would think we should use the sha either way, instead of the tag IMO.

@sozercan
Copy link
Author

@longwuyuan

a few issues here:

  • in Helm chart, this settings doesn't need to be enabled by default (do not require --default-backend-service #3126 removed the need for this unless there is a custom backend)
  • Image is moved to ingress-gce repo. However, default image in the chart is an old one that was produced by ingress-nginx repo that won't get any new changes like multi-arch

@longwuyuan
Copy link
Contributor

I am lost. Line 744 shows enabled: false

image

@sozercan
Copy link
Author

ah my bad, I must be looking at an old or a modified chart then. Thanks! I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants