Welcome defaultbackend to the ingress-gce repo

[jonpulsifer]

This commit introduces the 404-server to the ingress-gce repository.

Previously, it was held in the kubernetes/ingress-nginx repo, but the
nginx ingress controller no longer requires it.

Fixes #498

Signed-off-by: Jonathan Pulsifer [email protected]

[aledbf]

@bowei friendly ping

[bowei]

@jonpulsifer -- is it possible to split into two commits:

1. with all the changes needs to wire in the new code
2. just the code copied over

It's hard to review in the github UI otherwise

[rramkumar1]

/ok-to-test

[jonpulsifer]

This PR just introduces the new code, there's nothing wired in. What changes need to be made for this to be wired in? 😄

[rramkumar1]

@jonpulsifer Thanks for the PR. If I may, I'd like to make a suggestion on how to better structure this PR in order to be more consistent w/ how we structure the other binaries we manage in this repo.

You can take the echo server binary as an example (cmd/echo). Specifically, I would like to see the actual server code under cmd/404 or something like that w/ a corresponding Dockerfile + Makefile target in the top level. There is also no need for a cloudbuild.yaml given that we have our own internal build + push process.

Also, we don't really care for the prometheus metrics so is it possible to just get rid of that? That will save us from Godep as well.

Let me know if you have any questions.

[jonpulsifer]

Pardon the delay 😄

I think this is ok now? A few things:

1. 404-server now builds like the other binaries
2. metrics have been removed (byebye vendor/)
3. works on my machine 😂

The last nit, I think, is that the image builds with the following image name gcr.io/google_containers/ingress-gce-404-server-amd64

I assume we would like it to maintain its original name defaultbackend and version but I don't know how you'd like to do this.

Ref https://console.cloud.google.com/gcr/images/google_containers/GLOBAL/defaultbackend

[rramkumar1]

We don't need a separate OWNERS for this. The top level OWNERS should suffice.

[rramkumar1]

@jonpulsifer Can you also add the binary name to the Makefile?

Regarding the naming of the image, i'll ask around and get back to you ASAP

[jonpulsifer]

The binary was added in 4bb3afe and the owners have been removed

[rramkumar1]

@jonpulsifer Thanks alot, this looks great!

/lgtm
/hold

Will get back to you today regarding naming of the image.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonpulsifer, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rramkumar1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rramkumar1]

@jonpulsifer Naming is fine. I'll take care of updating any stale references

/hold remove

[rramkumar1]

/hold cancel