Unknown flag "size-buckets"

[nlybe]

NGINX Ingress controller
Release: v1.1.1
nginx version: nginx/1.19.9

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.3", GitCommit:"816c97ab8cff8a1c72eccca1026f7820e93e0d25", GitTreeState:"clean", BuildDate:"2022-01-25T21:25:17Z", GoVersion:"go1.17.6", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"20+", GitVersion:"v1.20.12-gke.1500", GitCommit:"d32c0db9a3ccd0ac73b0b3abd0532505217b376e", GitTreeState:"clean", BuildDate:"2021-11-17T09:30:02Z", GoVersion:"go1.15.15b5", Compiler:"gc", Platform:"linux/amd64"}

Helm version:
version.BuildInfo{Version:"v3.7.0", GitCommit:"eeac83883cb4014fe60267ec6373570374ce770b", GitTreeState:"clean", GoVersion:"go1.16.8"}

Environment:

• Cloud provider or hardware configuration: GCP GKE
• OS (e.g. from /etc/os-release): Container-Optimized OS from Google
• Kernel version: 5.4.144+

How was the ingress-nginx-controller installed:
Using helm template , using the command:

helm install ingress-nginx ingress-nginx/ingress-nginx --set controller.extraArgs.size-buckets="{0.05,0.1,0.3,0.5,1.0,5,10}"

Output of 'helm ls -A | grep -i ingress'
ingress-nginx default 1 2022-02-10 12:35:46.167462946 +0200 EET deployed ingress-nginx-4.0.17 1.1.1

Current State of the controller:

➜  kubectl get pod
NAME                                        READY   STATUS             RESTARTS   AGE
ingress-nginx-controller-7bdc9d4dc8-dtkc2   0/1     CrashLoopBackOff   10         27m

➜  kubectl describe ingressclasses
Name:         nginx
Labels:       app.kubernetes.io/component=controller
              app.kubernetes.io/instance=ingress-nginx
              app.kubernetes.io/managed-by=Helm
              app.kubernetes.io/name=ingress-nginx
              app.kubernetes.io/part-of=ingress-nginx
              app.kubernetes.io/version=1.1.1
              helm.sh/chart=ingress-nginx-4.0.17
Annotations:  meta.helm.sh/release-name: ingress-nginx
              meta.helm.sh/release-namespace: default
Controller:   k8s.io/ingress-nginx
Events:       <none>

➜  ~ kubectl logs -f ingress-nginx-controller-7bdc9d4dc8-dtkc2                                                  
-------------------------------------------------------------------------------
NGINX Ingress controller
  Release:       v1.1.1
  Build:         a17181e43ec85534a6fea968d95d019c5a4bc8cf
  Repository:    https://github.com/kubernetes/ingress-nginx
  nginx version: nginx/1.19.9

-------------------------------------------------------------------------------

unknown flag: --size-buckets
Usage of :
unknown flag: --size-buckets
.....
.....

What happened:

I installed ingress-nginx using helm and tried to set the flag size-buckets as it looks that it exists https://github.com/kubernetes/ingress-nginx/blob/main/cmd/nginx/flags.go and according that feature described here #7171.

The ingress-nginx deployment is successful but the pod is not starting and get the following message in pod logs "unknown flag: --size-buckets".

If try to use other flag, e.g. "enable-metrics" it works and accept the flag.

According the documentation at https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/cli-arguments.md, the flags time-buckets, length-buckets, size-buckets are not listed in list of arguments.

So the question is, how can I set these flags?

[k8s-ci-robot]

@nlybe: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kundan2707]

/remove-kind bug
/kind support

[kundan2707]

/remove-kind bug

[kundan2707]

helm install ingress-nginx ingress-nginx/ingress-nginx --set controller.extraArgs.size-buckets="{0.05,0.1,0.3,0.5,1.0,5,10}"

size-bucket is not part of configuration of controller so you cant set it as you did

https://github.com/kubernetes/ingress-nginx/blob/main/cmd/nginx/flags.go

size-bucket is parts of metrics not controller

[kundan2707]

/assign

[kundan2707]

So the question is, how can I set these flags?

you cannot et these flag with command line. you need to set these in config file

[kundan2707]

@nlybe if your problem got resolved then you can close this issue.

[nlybe]

@kundan2707 thanks for your replies. Actually it's not clear to me how to use this feature with helm if I can't use variables in values yaml file. Which config file do you mean?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vitobotta]

@nlybe HI, did you manage to use this configuration? Where should I put it if I cannot do it with the values for the helm chart? Thanks

[voron]

Just for the history, I was able to use time-buckets with NGINX Ingress controller v1.4.0 and helm chart ingress-nginx/ingress-nginx version 4.3.0 via following helm values

controller:
  extraArgs:
    time-buckets: "0.005,0.01,0.025,0.05,0.1,0.25,0.5,1,2.5,5,10,20,30,45,60,90,120"

[sde-melo]

@voron Thank you! I was about to commit suicide.