Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove curl dependencies in e2e tests #9716

Closed
strongjz opened this issue Mar 11, 2023 · 4 comments · Fixed by #10296 or #10306
Closed

Remove curl dependencies in e2e tests #9716

strongjz opened this issue Mar 11, 2023 · 4 comments · Fixed by #10296 or #10306
Assignees
@strongjz @sonbui00
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@strongjz
Copy link
Member

In order to remove curl from our controller container, we need to remove curl dependencies in our e2e tests.

https://github.com/search?q=repo%3Akubernetes%2Fingress-nginx%20curlCmd&type=code

These tests should move the http requests to our dbg container which uses nginx for requests.

https://github.com/kubernetes/ingress-nginx/blob/main/cmd/dbg/main.go

https://github.com/kubernetes/ingress-nginx/blob/main/internal/nginx/main.go#L65
@strongjz strongjz added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strongjz strongjz self-assigned this Mar 11, 2023
@tao12345666333
Copy link
Member

great! +1

@github-actions
Copy link

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

@github-actions github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 12, 2023
@sonbui00
Copy link
Contributor

/assign

sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 11, 2023
@sonbui00
fix: Replace curl list backend with dbg command kubernetes#9716
061d4d8 
Signed-off-by: Son Bui <[email protected]>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 11, 2023
@sonbui00
fix: Remove curl dependencies in e2e tests kubernetes#9716
57aaceb 
Signed-off-by: Son Bui <[email protected]>
@sonbui00 sonbui00 mentioned this issue Aug 11, 2023
Merged
5 tasks
k8s-ci-robot pushed a commit that referenced this issue Aug 12, 2023
@sonbui00
Remove curl dependencies in e2e tests #9716 (#10296)
a92e7b4 
* fix: Replace curl list backend with dbg command #9716

Signed-off-by: Son Bui <[email protected]>

* fix: Remove curl dependencies in e2e tests #9716

Signed-off-by: Son Bui <[email protected]>

---------

Signed-off-by: Son Bui <[email protected]>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 12, 2023
@sonbui00
fix: remove curl on base container kubernetes#9716
94f8735
@sonbui00 sonbui00 mentioned this issue Aug 12, 2023
Merged
5 tasks
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 14, 2023
@sonbui00
fix: remove curl on chroot container kubernetes#9716
b577577 
Signed-off-by: Son Bui <[email protected]>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 14, 2023
@sonbui00
fix: remove curl on test runner image kubernetes#9716
8e7c63a 
Signed-off-by: Son Bui <[email protected]>
sonbui00 added a commit to sonbui00/ingress-nginx that referenced this issue Aug 14, 2023
@sonbui00
fix: remove curl on e2e runner container kubernetes#9716
670a669 
Signed-off-by: Son Bui <[email protected]>
k8s-ci-robot pushed a commit that referenced this issue Sep 8, 2023
@sonbui00
fix: remove curl on base container #9716 (#10306)
4664b74 
* fix: remove curl on base container #9716

* fix: remove curl on chroot container #9716

Signed-off-by: Son Bui <[email protected]>

* fix: remove curl on test runner image #9716

Signed-off-by: Son Bui <[email protected]>

* fix: remove curl on e2e runner container #9716

Signed-off-by: Son Bui <[email protected]>

---------

Signed-off-by: Son Bui <[email protected]>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
@sonbui00
fix: remove curl on base container kubernetes#9716
785974a
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
@sonbui00
fix: remove curl on chroot container kubernetes#9716
a0a0d57 
Signed-off-by: Son Bui <[email protected]>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
@sonbui00
fix: remove curl on test runner image kubernetes#9716
9b87786 
Signed-off-by: Son Bui <[email protected]>
k8s-infra-cherrypick-robot pushed a commit to k8s-infra-cherrypick-robot/ingress-nginx that referenced this issue Sep 8, 2023
@sonbui00
fix: remove curl on e2e runner container kubernetes#9716
eab3359 
Signed-off-by: Son Bui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@strongjz strongjz

@sonbui00 sonbui00

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
[SIG Network] Ingress NGINX
Archived in project
Milestone
No milestone
4 participants
@strongjz @tao12345666333 @sonbui00 @k8s-ci-robot