-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add golangci github action and replace the deprecated golint #10187
Conversation
Signed-off-by: z1cheng <[email protected]>
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @z1cheng. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
/ok-to-test |
Signed-off-by: z1cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
Signed-off-by: z1cheng <[email protected]>
@z1cheng now you have to fix the lints 😄 |
/hold |
I think we should also keep a makefile entry to run golang-ci locally. |
@tao12345666333 Now only I can add golint entry in makefile if necessary. |
Signed-off-by: Chen Chen <[email protected]>
Signed-off-by: Chen Chen <[email protected]>
…to add_golangci_action
…ess-nginx into add_golangci_action
This PR can be merged, since the lint errors has been fixed and it passed all checks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @rikatz
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, rikatz, z1cheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #10097
How Has This Been Tested?
Checklist: