-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS consistent indentation for serviceaccount.annotations #10254
DOCS consistent indentation for serviceaccount.annotations #10254
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @mattclegg. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Error: Failed to render chart: exit status 1: Error: YAML parse error on ingress-nginx/templates/controller-serviceaccount.yaml: error converting YAML to JSON: yaml: line 14: mapping values are not allowed in this context Use --debug flag to render out invalid YAML Error: plugin "diff" exited with error
812cc5d
to
65ab509
Compare
@mattclegg am I supposed to get the same error if I try this screenshot |
Ok, the issue was actually fixed earlier but this just makes the annotations yaml consistent with the style used in the rest of the chart. Thanks @longwuyuan I've updated the PR description. |
@longwuyuan can this one be merged? :) |
@rikatz No, I could not reproduce the problem this PR is expected to fix |
@longwuyuan The description was updated after your previous comment; now it's just fixing an inconsistency in the yaml. |
@mattclegg I am sorry because my comments need to be more clear for all readers and not be a blocker for improvements you have proposed. Can you help and create an issue that sort of details the problem you are fixing here. then link that issue here (there is a syntax like "fixes", that I know, becomes visible in a new PR template). That should help clarify. Regards and thanks for this contribution. Apologies taking time to merge. |
@longwuyuan It's a minor documentation/indentation change. It's not worth the time creating it as an "issue". |
I am so sorry but I am terribly confused.
Best regards |
Thanks for taking the time to check the PR @longwuyuan Documentation isn't just about
But only 1 instance of;
This (trivial) PR updates that 1 instance so the template is consistent. |
@mattclegg thnks for your patience and thanks for the contribution. /lgtm @strongjz @tao12345666333 PTAL |
Anything else needed @cpanato ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind cleanup
/priority important-soon
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, longwuyuan, mattclegg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Consistent indentation for serviceaccount.annotations
Types of changes
Which issue/s this PR fixes
Fix indentation to be consistent.
How Has This Been Tested?
Rendered locally.
Checklist: