-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment/DaemonSet: Template topologySpreadConstraints
.
#10259
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
Hi @Gacko. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
topologySpreadConstraints
.topologySpreadConstraints
templateable.
topologySpreadConstraints
templateable.topologySpreadConstraints
.
6536dc9
to
66e193a
Compare
65788ab
to
8450d15
Compare
6ee9da2
to
cd101b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What this PR does / why we need it:
This PR makes the
topologySpreadConstraints
in both theDeployment
and theDaemonSet
templateable so one can reuse the Helm release name and does not need to configure the selector labels for every instance manually.Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: