-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gzip instead of pigz in CI #10348
Conversation
Signed-off-by: Ciprian Hacman <[email protected]>
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/kind failing-test |
/ok-to-test |
/priority important-soon @tao12345666333 @strongjz if replacing pigz command with gzip command will not impact anywhere else, then PTAL and review/approve |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Replacing with gzip won't cause any issues except for some performance differences. I agree to replace with gzip so that we can prioritize ensuring that our CI is not affected by the missing pigz package in GitHub Actions. Once this issue is resolved, we can switch back to pigz.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, longwuyuan, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @tao12345666333. |
Yes. Perhaps we won't switch back to pigz again, it's just a small note. |
What this PR does / why we need it:
CI tests are failing due to missing pigz binary.
Ref: #10335
Root cause tracked to new runner images being released without the
pigz
package installed:actions/runner-images#8161.
Types of changes
Which issue/s this PR fixes
n/a
How Has This Been Tested?
n/a
Checklist: