-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firewall configuration to quick start documentation #10357
Conversation
|
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Welcome @rudolfbyker! |
Hi @rudolfbyker. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rudolfbyker thanks for the improvement contribution /ok-to-test |
/kind documentation |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, rudolfbyker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, the only place in the docs that port 8443 is mentioned is under the GCE / GKE docs at https://kubernetes.github.io/ingress-nginx/deploy/#gce-gke . This has caused some confusion, e.g. at https://kubernetes.slack.com/archives/CANQGM8BA/p1693290937903399?thread_ts=1693224605.897199&cid=CANQGM8BA . Since port 8443 must always be open between kubernetes nodes for ingress-nginx to work properly, we should add it to the quick-start installation documentation.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: