Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.21.1 #10377

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 7, 2023

Bumping go version before release
/triage accepted
/kind bug
/priority urgent

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. labels Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

@rikatz: The label(s) priority/urgent cannot be applied, because the repository doesn't have them.

In response to this:

Bumping go version before release
/triage accepted
/kind bug
/priority urgent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit e89ef55
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64fa344d12b2060009f44b9e

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Sep 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
@rikatz rikatz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8b85bad into kubernetes:main Sep 7, 2023
6 checks passed
@rikatz
Copy link
Contributor Author

rikatz commented Sep 7, 2023

/cherrypick release-1.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

@rikatz: #10377 failed to apply on top of branch "release-1.8":

Applying: Bump Go version to 1.21.1
error: patch failed: images/opentelemetry/rootfs/go.mod:1
error: images/opentelemetry/rootfs/go.mod: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M	.github/workflows/ci.yaml
A	.github/workflows/golangci-lint.yml
M	.github/workflows/plugin.yaml
M	go.mod
M	go.sum
M	images/custom-error-pages/rootfs/Dockerfile
Patch failed at 0001 Bump Go version to 1.21.1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rikatz added a commit to rikatz/ingress-nginx that referenced this pull request Sep 7, 2023
* Bump Go version to 1.21.1

* Bump testrunner image
k8s-ci-robot pushed a commit that referenced this pull request Sep 8, 2023
* Bump Go version to 1.21.1 (#10377)

* Bump Go version to 1.21.1

* Bump testrunner image

* Fix lint error on datadog struct

* Revert lint on 1.8

* Fix http default backend test

* Fix http default backend test

* Fix http default backend test (#10382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants