Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e test suite doc #10396

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Fix e2e test suite doc #10396

merged 3 commits into from
Sep 11, 2023

Conversation

z1cheng
Copy link
Member

@z1cheng z1cheng commented Sep 11, 2023

What this PR does / why we need it:

Run ./hack/generate-e2e-suite-doc.sh > docs/e2e-tests.md to regenerate the doc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #10395

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: z1cheng <[email protected]>
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit fd13525
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64fea870bc3fc6000842d666
😎 Deploy Preview https://deploy-preview-10396--kubernetes-ingress-nginx.netlify.app/e2e-tests
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @z1cheng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/docs needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 11, 2023

- [](https://github.com/kubernetes/ingress-nginx/tree/main/test/e2e/settings/badannotationvalues.go#L)
- [](https://github.com/kubernetes/ingress-nginx/tree/main/test/e2e/framework/httpexpect/array.go#L)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test cases still were not generated

@z1cheng
Copy link
Member Author

z1cheng commented Sep 11, 2023

Some test cases still were not generated, need to debug the script

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 11, 2023
@z1cheng
Copy link
Member Author

z1cheng commented Sep 11, 2023

Fix the script to:

  1. ignore no Describe.* files
  2. skip some basic framework files

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2023
@tao12345666333
Copy link
Member

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tao12345666333, z1cheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3d69d9a into kubernetes:main Sep 11, 2023
38 checks passed
@z1cheng z1cheng deleted the fix_e2e_doc branch September 11, 2023 08:24
@strongjz
Copy link
Member

This is breaking for me now.....

./hack/generate-e2e-suite-doc.sh: line 24: /Users/strongjz/Documents/code/go/src/github.com/kubernetes/ingress-nginx/test/e2e/framework/framework.go: syntax error: operand expected (error token is "/Users/strongjz/Documents/code/go/src/github.com/kubernetes/ingress-nginx/test/e2e/framework/framework.go")
./hack/generate-e2e-suite-doc.sh: line 37: /Users/strongjz/Documents/code/go/src/github.com/kubernetes/ingress-nginx/test/e2e/metrics/metrics.go: syntax error: operand expected (error token is "/Users/strongjz/Documents/code/go/src/github.com/kubernetes/ingress-nginx/test/e2e/metrics/metrics.go")
2023-09-12T12:44:50+02:00 ERROR Could not run update hack script running "./hack/generate-e2e-suite-doc.sh " failed with exit code 1

@z1cheng
Copy link
Member Author

z1cheng commented Sep 13, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix e2e test suite doc
4 participants