-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Keep title in navbar in upcase #10755
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Welcome @pan3793! |
Hi @pan3793. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please sign the cla |
/check-cla |
/ok-to-test |
@pan3793 As pointed out earlier, please sign the CLA |
CLA signed |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, longwuyuan, pan3793 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@longwuyuan absolutely yes |
interesting, in the preview i was able to see that |
The netlify preview is good. Its on the live prod URL that I am not seeing the uppercase G, even in a private browser window. I see the code in main and I think that yaml file got the uppercase, so asking if either of you can double check and confirm that you can see the uppercase G in a private-window of your browser to at least rule out the laptop cache. If you are seeing uppercase G in the https://kubernetes.github.io/ingress-nginx/ url, then my bad |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
N/A
How Has This Been Tested?
Checklist: