[charts/ingress-nginx] add Service Internal Traffic Policy enables in… #10804

opencmit2 · 2023-12-25T02:28:02Z

…ternal traffic restrictions

What this PR does / why we need it:

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
CVE Report (Scanner found CVE and adding report)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added unit and/or e2e tests to cover my changes.
All new and existing tests passed.

…ternal traffic restrictions Signed-off-by: JinXinWang <[email protected]>

linux-foundation-easycla · 2023-12-25T02:28:06Z

The committers listed above are authorized under a signed CLA.

✅ login: opencmit2 (c91683b, b4b80c8, a749323, 0683366, 81f77a2, 8d72a57, 5078ed1, 73137b8, 088436d)

netlify · 2023-12-25T02:28:08Z

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	`b4b80c8`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65e6b6a7a7904800072202f5

k8s-ci-robot · 2023-12-25T02:28:10Z

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2023-12-25T02:28:10Z

Welcome @opencmit2!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-12-25T02:28:11Z

Hi @opencmit2. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

github-actions · 2024-02-09T01:48:03Z

This is stale, but we won't close it automatically, just bare in mind the maintainers may be busy with other tasks and will reach your issue ASAP. If you have any question or request to prioritize this, please reach #ingress-nginx-dev on Kubernetes Slack.

k8s-triage-robot · 2024-02-09T04:21:43Z

The lifecycle/frozen label can not be applied to PRs.

This bot removes lifecycle/frozen from PRs because:

Commenting /lifecycle frozen on a PR has not worked since March 2021
PRs that remain open for >150 days are unlikely to be easily rebased

You can:

Rebase this PR and attempt to get it merged
Close this PR with /close

Please send feedback to sig-contributor-experience at kubernetes/community.

/remove-lifecycle frozen

strongjz · 2024-02-29T21:02:48Z

@opencmit2 please remove the version update, rebase, and check the e2e tests that our failing with the helm charts.

opencmit2 · 2024-03-04T02:08:39Z

@strongjz
This is my first contribution, I'm not very good at making modifications. Do you have any suggestions?

strongjz · 2024-03-04T02:27:30Z

charts/ingress-nginx/Chart.yaml

@@ -24,4 +24,4 @@ maintainers:
 name: ingress-nginx
 sources:
 - https://github.com/kubernetes/ingress-nginx
-version: 4.9.0


Remove this

Hi @strongjz
Revisions have been made. Please review.

aofei · 2024-03-05T01:42:14Z

charts/ingress-nginx/Chart.yaml

You just changed it again. I believe the intention was to leave it alone. In other words, don't touch this file in your branch.

@aofei
I have restored.

Then resolve the failed checks below. For example https://github.com/kubernetes/ingress-nginx/actions/runs/8149768719/job/22275053770?pr=10804#step:7:127.

Hi @aofei
Revisions have been made. Please review.

Signed-off-by: JinXinWang <[email protected]>

aofei

@opencmit2

I'm not an ingress-nginx maintainer. I'm just a random guy on the internet willing to help with your first contribution. You need to request reviews from the maintainers.

LGTM though.

k8s-ci-robot · 2024-03-05T08:22:38Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aofei, opencmit2
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

charts/ingress-nginx/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

opencmit2 · 2024-03-05T13:01:24Z

Hi @strongjz
Revisions have been made. Please review.

opencmit2 · 2024-03-05T13:02:57Z

@aofei Thanks a lot

Gacko · 2024-08-26T22:27:08Z

Closing this for the same reason as #10798.

[charts/ingress-nginx] add Service Internal Traffic Policy enables in…

c91683b

…ternal traffic restrictions Signed-off-by: JinXinWang <[email protected]>

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/helm Issues or PRs related to helm charts labels Dec 25, 2023

k8s-ci-robot requested review from cpanato and strongjz December 25, 2023 02:28

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 25, 2023

k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 25, 2023

github-actions bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 9, 2024

k8s-ci-robot removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 9, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2024

opencmit2 added 2 commits March 4, 2024 09:50

Update Chart.yaml

81f77a2

Update Chart.yaml

088436d

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2024

strongjz requested changes Mar 4, 2024

View reviewed changes

opencmit2 added 2 commits March 5, 2024 09:34

Merge branch 'kubernetes:main' into devel/add_10798

0683366

Update Chart.yaml

a749323

aofei reviewed Mar 5, 2024

View reviewed changes

opencmit2 and others added 4 commits March 5, 2024 09:44

Update Chart.yaml

8d72a57

Update values.yaml

5078ed1

Revert changes to README file

73137b8

Signed-off-by: JinXinWang <[email protected]>

Use helm-docs to modify the README file

b4b80c8

Signed-off-by: JinXinWang <[email protected]>

aofei approved these changes Mar 5, 2024

View reviewed changes

Gacko closed this Aug 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[charts/ingress-nginx] add Service Internal Traffic Policy enables in… #10804

[charts/ingress-nginx] add Service Internal Traffic Policy enables in… #10804

opencmit2 commented Dec 25, 2023 •

edited

Loading

linux-foundation-easycla bot commented Dec 25, 2023 •

edited

Loading

netlify bot commented Dec 25, 2023 •

edited

Loading

k8s-ci-robot commented Dec 25, 2023

k8s-ci-robot commented Dec 25, 2023

k8s-ci-robot commented Dec 25, 2023

github-actions bot commented Feb 9, 2024

k8s-triage-robot commented Feb 9, 2024

strongjz commented Feb 29, 2024

opencmit2 commented Mar 4, 2024

strongjz Mar 4, 2024

opencmit2 Mar 5, 2024

aofei Mar 5, 2024

opencmit2 Mar 5, 2024

aofei Mar 5, 2024

opencmit2 Mar 5, 2024

aofei left a comment

k8s-ci-robot commented Mar 5, 2024

opencmit2 commented Mar 5, 2024

opencmit2 commented Mar 5, 2024

Gacko commented Aug 26, 2024

[charts/ingress-nginx] add Service Internal Traffic Policy enables in… #10804

[charts/ingress-nginx] add Service Internal Traffic Policy enables in… #10804

Conversation

opencmit2 commented Dec 25, 2023 • edited Loading

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

linux-foundation-easycla bot commented Dec 25, 2023 • edited Loading

netlify bot commented Dec 25, 2023 • edited Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

k8s-ci-robot commented Dec 25, 2023

k8s-ci-robot commented Dec 25, 2023

k8s-ci-robot commented Dec 25, 2023

github-actions bot commented Feb 9, 2024

k8s-triage-robot commented Feb 9, 2024

strongjz commented Feb 29, 2024

opencmit2 commented Mar 4, 2024

strongjz Mar 4, 2024

Choose a reason for hiding this comment

opencmit2 Mar 5, 2024

Choose a reason for hiding this comment

aofei Mar 5, 2024

Choose a reason for hiding this comment

opencmit2 Mar 5, 2024

Choose a reason for hiding this comment

aofei Mar 5, 2024

Choose a reason for hiding this comment

opencmit2 Mar 5, 2024

Choose a reason for hiding this comment

aofei left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Mar 5, 2024

opencmit2 commented Mar 5, 2024

opencmit2 commented Mar 5, 2024

Gacko commented Aug 26, 2024

opencmit2 commented Dec 25, 2023 •

edited

Loading

linux-foundation-easycla bot commented Dec 25, 2023 •

edited

Loading

netlify bot commented Dec 25, 2023 •

edited

Loading