Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL build test and for NGINX v1.25 #10889

Merged
merged 8 commits into from
Jan 27, 2024

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Jan 21, 2024

What this PR does / why we need it:

As we are building OTEL externally, we need at least to test its image build before merging

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2024
Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 54432a1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65b50796f9a4a80008c13568

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2024
@rikatz
Copy link
Contributor Author

rikatz commented Jan 22, 2024

/assign @esigo

@rikatz rikatz force-pushed the add-otel-test branch 4 times, most recently from 4cf1f2c to 64fca82 Compare January 25, 2024 00:56
@rikatz
Copy link
Contributor Author

rikatz commented Jan 25, 2024

stuff to fix:

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/nginx.conf:279
2024/01/25 23:53:14 [warn] 85#85: the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/nginx.conf:280
nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/nginx.conf:280

@tao12345666333
Copy link
Member

/retest

@rikatz
Copy link
Contributor Author

rikatz commented Jan 26, 2024

will check later what I broke with my last commit

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2024
@rikatz rikatz force-pushed the add-otel-test branch 3 times, most recently from fb73ef4 to 68c2eb3 Compare January 26, 2024 19:16
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2024
@rikatz rikatz force-pushed the add-otel-test branch 2 times, most recently from 67c76e0 to 22212a0 Compare January 26, 2024 20:29
.github/workflows/ci.yaml Show resolved Hide resolved
images/nginx-1.25/rootfs/Dockerfile Outdated Show resolved Hide resolved
images/nginx-1.25/rootfs/build.sh Outdated Show resolved Hide resolved
test/e2e/wait-for-nginx.sh Outdated Show resolved Hide resolved
rootfs/etc/nginx/template/nginx.tmpl Show resolved Hide resolved
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold wait for CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm


FROM cgr.dev/chainguard/go:latest as build-init
FROM golang:1.21.6-bullseye as build-init
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use bookworm?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,rikatz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz
Copy link
Contributor Author

rikatz commented Jan 27, 2024

/hold cancel
Boooooooom

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 02e6ebc into kubernetes:main Jan 27, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants