-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Remove useless default
from _params.tpl
.
#10957
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/assign @strongjz |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.9 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Gacko: new pull request created: #10960 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The
_params.tpl
currently contains a check ifcontroller.scope.namespaceSelector
is non-empty, but still uses thedefault
directive when actually using the check value. This PR removes this unnecessary check.Types of changes
How Has This Been Tested?
CI.
Checklist: