-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade headers-more module to 0.37 #10991
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @milas! |
Hi @milas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
openresty/headers-more-nginx-module@v0.34...v0.37 Signed-off-by: Milas Bowman <[email protected]>
b1a06e9
to
b85ce01
Compare
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: milas, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.9 |
@strongjz: #10991 failed to apply on top of branch "release-1.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Oh no, I broke the cherry-pick bot because I fixed the comment in the 1.25 image 😭 |
I'm happy to do a manual PR / Thanks for the review/merge 🙂 |
FTR: this changed the behaviour for handling of multiple headers of the same name. See https://kubernetes.slack.com/archives/CANQGM8BA/p1718618298930939 We just painfully discovered, that v1.10.0 upgraded the dependency
pre 1.10.0 "corrected" this to
while post 1.10.0 appends the values
Granted, sending the same header multiple times is the culprit. Nevertheless, this caught us off guard. |
What this PR does / why we need it:
Upgrade to v0.37 of the
headers-more
module.Changelog: openresty/headers-more-nginx-module@v0.34...v0.37
Types of changes
Which issue/s this PR fixes
n/a
How Has This Been Tested?
I'm currently unable to test this locally as I cannot successfully build a fully functioning controller image right now. (I'm getting unknown directive
http2
?)Checklist: