chore(owasp-crs): Update OWASP CRS to v4.0.0

[NeckBeardPrince]

Bumps OWASP CRS to latest, v4.0.0

What this PR does / why we need it:

The OWASP Core Rule Set has been updated to v4.0.0.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rikatz / name: Ricardo Katz (0e35b4651f7090406b9bd6a00dd3bbce10cd37d5)
• ✅ login: NeckBeardPrince / name: Adam Stracener (da7027176cfb4cf5578a87167ceb582ce60c29b3, b1122fa2c8e2ee00016056b87cdf104d2b8ff498)
• ✅ login: dependabot[bot] (9daa483c2e08c10ce8c833bbba92cf0a9472c565, 7fd3e158b0ca5531a9da713bbd7bac811ed3d527)
• ✅ login: milas / name: Milas Bowman (61db303a9b514c4e36273b5b332fbdeeb7297a34)

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @NeckBeardPrince!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @NeckBeardPrince. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	0a87031
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65dd402a636a8a00087a53b2

[rikatz]

Before we merge it, can you do some manual tests and confirm there is no breaking change on how modsecurity operates with this new rules.

eg.: does it need some fix on some rule? some action? does it represents some positive or negative performance impact?

Because this is a major version after so long, I'm worried about simply merging it and breaking real use cases

/hold

[rikatz]

@NeckBeardPrince as a way to test it, please change this value in https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx-1.25/rootfs/build.sh#L45

This is our new image that should be released with Ingress v1.10, if you can make it pass we can ship it on the new release.

Thanks!

[rikatz]

Also, if it passes, the TAG https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx-1.25/TAG should be bumped

[NeckBeardPrince]

@NeckBeardPrince as a way to test it, please change this value in https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx-1.25/rootfs/build.sh#L45

This is our new image that should be released with Ingress v1.10, if you can make it pass we can ship it on the new release.

Thanks!

Bumped tag and the build ran fine.

edit: Looks like we did the same thing.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NeckBeardPrince

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rikatz]

Hey, I didn't merged the coreruleset. Which commit I did for it?

[NeckBeardPrince]

Hey, I didn't merged the coreruleset. Which commit I did for it?

I have no idea why the PR got closed.

[NeckBeardPrince]

@rikatz I created a new PR #11025