-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quotes around numbers for the ports definitions #11052
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @fenio. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fenio, ubergesundheit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle quotes around numbers for the ports definitions |
/cherry-pick release-1.10 |
@Gacko: new pull request created: #11092 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is 2nd approach for #10969 so below is mostly copy from previous attempt.
What this PR does / why we need it:
I've just wasted 2 hours with errors like "var substitution failed for 'ingress-nginx-private': json: unsupported type: map[interface {}]interface {}" because examples shown in values.yaml don't include quotes for port numbers used for tcp/udp services. It's pretty common issue in YAML world when key is numerical. Just want to avoid same headache for others.
Types of changes
How Has This Been Tested?
On my homelab.
This works:
"53": network/dnsmasq:9553
This doesn't:
53: network/dnsmasq:9553
Checklist: