Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor helm ci tests part I #11178

Merged
merged 5 commits into from
Mar 31, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 29, 2024

What this PR does / why we need it:

Working to remove legacy and make easier to do maintenance for the helm ci tests (for now)

this pr uses the ct testing for lint and remove the script, more to come

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2024
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit b0a5410
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6606f102b8ba710008576cea

Signed-off-by: cpanato <[email protected]>
@k8s-ci-robot k8s-ci-robot added the area/helm Issues or PRs related to helm charts label Mar 29, 2024
Signed-off-by: cpanato <[email protected]>
@cpanato
Copy link
Member Author

cpanato commented Mar 29, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2024
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato force-pushed the refactor-helm-ci-part-1 branch 2 times, most recently from a961eab to 2f43885 Compare March 29, 2024 16:45
Signed-off-by: cpanato <[email protected]>
@cpanato cpanato added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 29, 2024
@strongjz
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2024
@strongjz
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c0767cc into kubernetes:main Mar 31, 2024
17 of 18 checks passed
@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

@cpanato: I was already working on this: #10815

@cpanato cpanato deleted the refactor-helm-ci-part-1 branch April 1, 2024 10:04
@cpanato
Copy link
Member Author

cpanato commented Apr 1, 2024

@cpanato: I was already working on this: #10815

oh sorry, can you rebase your PR and then we get that merged?

@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

Na, that was no complaint at all! Sorry! I just wanted to note that I was also working on similar stuff. My PR isn't ready, yet, since I also wanted to fix the CI values in the ci directory but did not manage to complete, yet. I'm already rebasing my PR every now and then, especially when CI changes fly in. 🙂

@cpanato
Copy link
Member Author

cpanato commented Apr 1, 2024

Na, that was no complaint at all! Sorry! I just wanted to note that I was also working on similar stuff. My PR isn't ready, yet, since I also wanted to fix the CI values in the ci directory but did not manage to complete, yet. I'm already rebasing my PR every now and then, especially when CI changes fly in. 🙂

ok lets sync, because i am trying to get rid from the e2e runner image to be more lightweight, but i can do after your PR

@Gacko
Copy link
Member

Gacko commented Apr 1, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11188

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants