-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update kube version requirement to 1.21 #11275
fix: update kube version requirement to 1.21 #11275
Conversation
The controller depends on the v1 version of EndpointSlice, but the discovery.k8s.io/v1 API was first introduced in Kubernetes version 1.21.
Hi @NierYYDS. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
Error got from controller
|
@NierYYDS thanks for catching this. Good catch https://kubernetes.io/docs/reference/using-api/deprecation-guide/#endpointslice-v125 @rikatz @tao12345666333 @Gacko @strongjz this needs to go in before controller v1.10.1. Please review/approve /triage accepted |
/ok-totest |
@NierYYDS the requirement of K8S v1.21.1 is met by the current value of |
And now we have to figure out if someone explicitly uses port 30090 instead of allowing random portnumber picking or is this a flake etc (error seen in CI) Error: INSTALLATION FAILED: Service "ingress-nginx-eaugyxlswn-controller" is invalid: spec.ports[2].nodePort: Invalid value: 30090: provided port is already allocated |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, NierYYDS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Gacko: new pull request created: #11279 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@longwuyuan |
thanks. The PR is merged AFAIK |
The controller depends on the v1 version of EndpointSlice, but the discovery.k8s.io/v1 API was first introduced in Kubernetes version 1.21.
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: