Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove opentracing and zipkin components mentions from docs #11361

Conversation

LucasAndFlores
Copy link
Contributor

@LucasAndFlores LucasAndFlores commented May 14, 2024

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #11042

How Has This Been Tested?

You can run the command live-docs and check the docs updated.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

Copy link

linux-foundation-easycla bot commented May 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: LucasAndFlores / name: Lucas Andrade Flores (2b26337)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @LucasAndFlores!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @LucasAndFlores. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 2b26337
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66450deb114a1a0008cb8173

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 14, 2024
@longwuyuan
Copy link
Contributor

longwuyuan commented May 15, 2024

@LucasAndFlores thank you for this contribution. Helps.

  • Are completely done with this or is there more opentracing related cleanup you are looking at.
  • Do you intend to work on removing zipkin or other content also.

I think we can go ahead with this if there is no more changes you are expecting to make. I will also check if there is any tiny nits

/kind documentation
/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. kind/documentation Categorizes issue or PR as related to documentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 15, 2024
@longwuyuan
Copy link
Contributor

@LucasAndFlores there is a github bot to squash commits. But if its possible, please consider to squash your commits yourself. Just to help as history here can be relatively cleaner that way. thank you

@LucasAndFlores
Copy link
Contributor Author

@longwuyuan Sure, I'll squash the commits. And from my side, I don't see any other change. If you find something necessary to change, tag me and I can make it.

@LucasAndFlores LucasAndFlores force-pushed the remove_deprecated_components_from_docs branch from 57877f0 to 2b26337 Compare May 15, 2024 19:32
@LucasAndFlores
Copy link
Contributor Author

@longwuyuan The squash is done 🙂 If any other change is necessary, feel free to tag me.

@longwuyuan
Copy link
Contributor

I see the significant reference to opentracing and zipkin gone. So maybe better to get this done first. If tnere are nits I missed,, maybe we can create a new issue to track the remianing work.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, LucasAndFlores

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 20d9a60 into kubernetes:main May 15, 2024
7 checks passed
@Gacko
Copy link
Member

Gacko commented May 31, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: #11361 failed to apply on top of branch "release-1.10":

Applying: Docs: Remove opentracing and zipkin from docs
Using index info to reconstruct a base tree...
M	docs/user-guide/nginx-configuration/annotations.md
M	docs/user-guide/nginx-configuration/configmap.md
Falling back to patching base and 3-way merge...
Removing docs/user-guide/third-party-addons/opentracing.md
Auto-merging docs/user-guide/nginx-configuration/configmap.md
CONFLICT (content): Merge conflict in docs/user-guide/nginx-configuration/configmap.md
Auto-merging docs/user-guide/nginx-configuration/annotations.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Docs: Remove opentracing and zipkin from docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated & unsupported components related content from docs
5 participants