-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove opentracing and zipkin components mentions from docs #11361
Remove opentracing and zipkin components mentions from docs #11361
Conversation
|
Welcome @LucasAndFlores! |
Hi @LucasAndFlores. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
@LucasAndFlores thank you for this contribution. Helps.
I think we can go ahead with this if there is no more changes you are expecting to make. I will also check if there is any tiny nits /kind documentation |
@LucasAndFlores there is a github bot to squash commits. But if its possible, please consider to squash your commits yourself. Just to help as history here can be relatively cleaner that way. thank you |
@longwuyuan Sure, I'll squash the commits. And from my side, I don't see any other change. If you find something necessary to change, tag me and I can make it. |
57877f0
to
2b26337
Compare
@longwuyuan The squash is done 🙂 If any other change is necessary, feel free to tag me. |
I see the significant reference to opentracing and zipkin gone. So maybe better to get this done first. If tnere are nits I missed,, maybe we can create a new issue to track the remianing work. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, LucasAndFlores The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@Gacko: #11361 failed to apply on top of branch "release-1.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #11042
How Has This Been Tested?
You can run the command
live-docs
and check the docs updated.Checklist: