Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Ingress-NGINX v1.10.1 compatibility with Kubernetes v1.30 #11495

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

adzinzhalifunnas
Copy link
Contributor

@adzinzhalifunnas adzinzhalifunnas commented Jun 24, 2024

Update the documentation to reflect the successful testing and compatibility of Ingress-NGINX v1.10.1 with Kubernetes v1.30. This change ensures that users are aware of the expanded compatibility beyond the previously documented Kubernetes v1.29 version.

Key updates:

This update aims to provide accurate and up-to-date information to users, enabling them to make informed decisions when deploying Ingress-NGINX v1.10.1 on Kubernetes v1.30.2 clusters.

Copy link

linux-foundation-easycla bot commented Jun 24, 2024

CLA Signed

  • ✅login: adzinzhalifunnas / (363c1b4)

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @adzinzhalifunnas!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @adzinzhalifunnas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit 363c1b4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66792318bd17b9000881c6e0
😎 Deploy Preview https://deploy-preview-11495--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 24, 2024
@longwuyuan
Copy link
Contributor

@adzinzhalifunnas thank you for this contribution.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2024
@longwuyuan
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@longwuyuan
Copy link
Contributor

/approve

@longwuyuan
Copy link
Contributor

@adzinzhalifunnas can you please edit the PR description and add "fixes #11494"

@adzinzhalifunnas
Copy link
Contributor Author

@adzinzhalifunnas can you please edit the PR description and add "fixes #11494"

done

@Gacko
Copy link
Member

Gacko commented Jun 24, 2024

/lgtm

@Gacko
Copy link
Member

Gacko commented Jun 24, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Jun 24, 2024

/triage accepted
/kind documentation
/priority backlgo

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jun 24, 2024
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

@Gacko: The label(s) priority/backlgo cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted
/kind documentation
/priority backlgo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 24, 2024
@Gacko
Copy link
Member

Gacko commented Jun 24, 2024

/priority backlog

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adzinzhalifunnas, Gacko, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority labels Jun 24, 2024
@Gacko
Copy link
Member

Gacko commented Jun 24, 2024

/unassign

@k8s-ci-robot k8s-ci-robot merged commit 8691884 into kubernetes:main Jun 24, 2024
7 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11500

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress-NGINX v1.10.1 Feature Availability on Kubernetes v1.30.2
5 participants