Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security: Follow-up on recent changes. #11874

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Security: Follow-up on recent changes. #11874

merged 9 commits into from
Aug 26, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Aug 26, 2024

Follow-up to #11819.

/triage accepted
/kind cleanup
/priority important-soon
/cc @rikatz @strongjz

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/docs area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 26, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 26, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit df3f5aa
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66ccca5f94b53900082a94a8

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 26, 2024
@strongjz
Copy link
Member

its not obvious, does this also we move the 3rd set of k8s tests with annotations validations on?

-james

@Gacko
Copy link
Member Author

Gacko commented Aug 26, 2024 •
edited
Loading

@rikatz already removed the validations tests in his PR here. So as of his PR, we already test with validations enabled by default.

@Gacko
Copy link
Member Author

Gacko commented Aug 26, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
rikatz
rikatz approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@rikatz rikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gacko
Copy link
Member Author

Gacko commented Aug 26, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit e9f6c8e into kubernetes:main Aug 26, 2024
27 checks passed
@Gacko Gacko deleted the jxwwj branch August 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz rikatz approved these changes

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gacko @strongjz @k8s-ci-robot @rikatz