Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart: Improve CI. #12003

Merged
merged 26 commits into from
Sep 28, 2024
Merged

Chart: Improve CI. #12003

merged 26 commits into from
Sep 28, 2024

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Sep 20, 2024 •
edited
Loading

What this PR does / why we need it:

This PR improves the existing chart tests by renaming & aligning unit (tests/) & E2E tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/docs area/helm Issues or PRs related to helm charts labels Sep 20, 2024
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 20, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 44f81b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/66f7e5a25fcaf60008a2a7f3

@Gacko Gacko changed the title Qyaa2 Chart: Improve CI. Sep 20, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2024
@Gacko Gacko force-pushed the qyaa2 branch 8 times, most recently from c777752 to a211aa9 Compare September 25, 2024 21:23
@Gacko
CI: Rework Cert Manager.
96a2440
@Gacko
CI: Rework chart testing.
2b5db6c
@Gacko
Chart: Rework Controller Deployment/DaemonSet values.
5c44423
@Gacko
Chart: Rework Controller Deployment/DaemonSet Pod Annotations values.
b40fae9
@Gacko
Chart: Rework Controller Deployment/DaemonSet Metrics values.
db5f293
@Gacko
Chart: Rework Controller Deployment/DaemonSet OpenTelemetry values.
d615e05
@Gacko
Chart: Rework Controller Deployment/DaemonSet Extra Modules values.
c273589
@Gacko
Chart: Rework Controller ConfigMap values.
6920b94
@Gacko
Chart: Rework Controller ConfigMap Add/Proxy Headers values.
331fb31
@Gacko
Chart: Rework Controller IngressClass values.
d987703
@Gacko
Chart: Rework Controller HPA values.
b11f3ed
@Gacko
Chart: Rework Controller Service values.
b4f74c0
@Gacko
Chart: Rework Controller Service Internal values.
b68dca9
@Gacko
Chart: Rework Admission Webhooks Cert Manager values.
44f81b2
@Gacko Gacko mentioned this pull request Sep 28, 2024
Merged
10 tasks
@cpanato cpanato added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 28, 2024
cpanato
cpanato approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f369ffb into kubernetes:main Sep 28, 2024
36 checks passed
@Gacko
Copy link
Member Author

Gacko commented Sep 28, 2024

/lgtm

Nice! A big step... I can hardly remember when I started working on this. 😅

@Gacko Gacko deleted the qyaa2 branch September 28, 2024 13:40
@Gacko
Copy link
Member Author

Gacko commented Sep 28, 2024

/cherry-pick release-1.10

@Gacko
Copy link
Member Author

Gacko commented Sep 28, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #12029

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #12030

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Sep 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@strongjz strongjz Awaiting requested review from strongjz

@ubergesundheit ubergesundheit Awaiting requested review from ubergesundheit

@rikatz rikatz Awaiting requested review from rikatz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gacko @k8s-ci-robot @k8s-infra-cherrypick-robot @ubergesundheit @cpanato