Set default value of report-node-internal-ip-address as true.

[gyliu513]

Using default value of report-node-internal-ip-address as true can
make sure the ingress can always return ADDRESS, this also keep
backward compatibility with ingress 0.9.0.beta.12 and its previous
releases.

/cc @aledbf

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

[k8s-reviewable]

This change is 

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aledbf

Assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gyliu513]

Set default value of report-node-internal-ip-address as true.

[aledbf]

@gyliu513 we cannot change this default. If the user wants to use the internal IP it must be done explicitly

[gyliu513]

Why not let the ingress itself to decide return internal or external ip? I think that we should keep default behavior as before: Using external ip as priority, but if no external ip, use internal ip. /cc @aledbf

[gyliu513]

The ingress 0.9.0.beta-12 behavior is Using external ip as priority, but if no external ip, use internal ip. We can let end user configure report-node-internal-ip-address as false if they do not want to use internal ip.

[aledbf]

Why not let the ingress itself to decide return internal or external ip?

Because internal IP only makes sense in minikube or baremetal where you already need to change the defaults like the use of nodePort

[gyliu513]

But this changed the behavior since 0.9.0-beta.12, when I upgrade, I have to manually add this parameter, I think this is not good behavior for upgrade, comments? @aledbf

[gyliu513]

Also I can see many customer using Kubernetes distribution in their own data center, and they usually do not have external ip, so that's why I want to set the default value as true.

[aledbf]

But this changed the behavior since 0.9.0-beta.12, when I upgrade, I have to manually add this parameter, I think this is not good behavior for upgrade, comments? @aledbf

The version 0.9.0-beta.12 was released on Aug 30, 2017, and the change of the defaults was requested by other users having the same problem with the opposite case than you.

[aledbf]

Also I can see many customer using Kubernetes distribution in their own data center, and they usually do not have external ip, so that's why I want to set the default value as true.

I understand that but most of the users are using a cloud provider, not baremetal. As I said, if you are using Kubernetes in baremetal you already have to change lots of configurations, like get used to deal with nodePorts or using something like metallb.

[gyliu513]

Thanks @aledbf , let me upgrade my ingress by setting the report-node-internal-ip-address as true by default for now.