-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCE/GKE proxy mentioned for Azure #2717
Conversation
GCE/GKE are part of Google cloud not azure, so the note "proxy protocol is not supported in GCE/GKE" does not apply for azure
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed the CLA |
/assign @ElvinEfendi |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, dsalamancaMS The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apologies for this terrible mistake in the docs. |
@dsalamancaMS thanks! |
Merging. |
Codecov Report
@@ Coverage Diff @@
## master #2717 +/- ##
=======================================
Coverage 40.95% 40.95%
=======================================
Files 72 72
Lines 5084 5084
=======================================
Hits 2082 2082
Misses 2713 2713
Partials 289 289 Continue to review full report at Codecov.
|
GCE/GKE are part of Google cloud not azure, so the note "proxy protocol is not supported in GCE/GKE" does not apply for azure
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: