Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start migration of helm chart #5159

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Start migration of helm chart #5159

merged 1 commit into from
Feb 24, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 24, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

/cc @ChiefAlexander

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 24, 2020
@codecov-io
Copy link

codecov-io commented Feb 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7e65b90). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5159   +/-   ##
=========================================
  Coverage          ?   58.51%           
=========================================
  Files             ?       88           
  Lines             ?     6860           
  Branches          ?        0           
=========================================
  Hits              ?     4014           
  Misses            ?     2406           
  Partials          ?      440

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e65b90...b42075a. Read the comment docs.

Copy link
Contributor

@ChiefAlexander ChiefAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@aledbf
Copy link
Member Author

aledbf commented Feb 24, 2020

/verify-owners

@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • ChiefAlexander
    • charts/ingress-nginx/OWNERS
  • taharah
    • charts/ingress-nginx/OWNERS

@aledbf
Copy link
Member Author

aledbf commented Feb 24, 2020

/verify-owners

@aledbf
Copy link
Member Author

aledbf commented Feb 24, 2020

/retest

@aledbf aledbf removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 24, 2020
@aledbf aledbf merged commit 624cb5f into kubernetes:master Feb 24, 2020
@aledbf aledbf deleted the chart branch February 24, 2020 20:07
@aledbf
Copy link
Member Author

aledbf commented Feb 25, 2020

xref: #5161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants