-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[helm chart] Use recommended labels and label helpers #5185
Conversation
Hi @naseemkullah. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few other spots look like they need updating:
https://github.com/kubernetes/ingress-nginx/pull/5185/files#diff-161e27e4dad3d26202569098ce0ec2b7R5
https://github.com/kubernetes/ingress-nginx/pull/5185/files#diff-e915735ed7b67ecdde92336342ab87caR24
https://github.com/kubernetes/ingress-nginx/pull/5185/files#diff-44dedea5f6edfcfcd4d0660143043785R24
Signed-off-by: Naseem <[email protected]>
Thanks @ChiefAlexander, changes applied. |
lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, naseemkullah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Use recommended labels in preparation for new helm chart.
Also use
include
function overtemplate
where applicable.Part of #5161
Types of changes
How Has This Been Tested?
Not tested, please review carefully.
Checklist: