-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helm] Add option to specify job label for ServiceMonitor #7020
[Helm] Add option to specify job label for ServiceMonitor #7020
Conversation
Hi @hamza3202. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ChiefAlexander |
/assign @cmluciano |
I have created this PR because I mistakenly closed the original PR. |
943efc0
to
64b5e5b
Compare
…-servicemonitor-joblabel
@ChiefAlexander can you review/merge this PR ASAP? I have had to do rebase a couple of times already. |
/ok-to-test |
/lgtm |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, hamza3202 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds an option to specify
spec.jobLabel
field for ServiceMonitor. Which can be used to configure prometheus job name based on the value of a label on the service. Using a label on the service as the job name helps organising the jobs and preventing clashes.Types of changes
How Has This Been Tested?
spec.jobLabel
is not set in the generated yaml. (controller.metrics.enabled
andcontroller.metrics.serviceMonitor.enabled
were set totrue
to enable generation of ServiceMonitor)controller.metrics.serviceMonitor.jobLabel
, A new field was added in ServiceMonitor with the correct value.Checklist: