Remove localhost calls from external names

[rikatz]

Signed-off-by: Ricardo Pchevuzinske Katz [email protected]

What this PR does / why we need it:

Removes the possibility of using localhost in ExternalNames as endpoints

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[codecov-commenter]

Codecov Report

Merging #7092 (ca36ee4) into master (bacd735) will increase coverage by 0.20%.
The diff coverage is 64.28%.

❗ Current head ca36ee4 differs from pull request most recent head 50c9764. Consider uploading reports for the commit 50c9764 to get more accurate results

@@            Coverage Diff             @@
##           master    #7092      +/-   ##
==========================================
+ Coverage   55.82%   56.03%   +0.20%     
==========================================
  Files          94       94              
  Lines        6588     6589       +1     
==========================================
+ Hits         3678     3692      +14     
+ Misses       2449     2436      -13     
  Partials      461      461              

Impacted Files	Coverage Δ
internal/ingress/controller/nginx.go	28.71% <ø> (ø)
internal/ingress/controller/store/store.go	58.94% <16.66%> (ø)
internal/ingress/controller/controller.go	46.80% <100.00%> (+0.12%)	⬆️
internal/ingress/controller/endpoints.go	93.47% <100.00%> (+0.62%)	⬆️
internal/ingress/types_equals.go	17.96% <100.00%> (+3.80%)	⬆️
...ternal/ingress/annotations/globalratelimit/main.go	64.70% <0.00%> (-0.30%)	⬇️
internal/ingress/controller/template/template.go	76.82% <0.00%> (-0.04%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ae0d3...50c9764. Read the comment docs.

[moonming]

/ok-to-test

[moonming]

/lgtm

[tao12345666333]

/hold

[ElvinEfendi]

/lgtm

[rikatz]

/hold cancel

[rikatz]

/hold

Wait for the cI

[ElvinEfendi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, moonming, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi,rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rikatz]

/hold cancel