Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for custom probes #7137

Merged
merged 4 commits into from
May 18, 2021
Merged

Add support for custom probes #7137

merged 4 commits into from
May 18, 2021

Conversation

brianharwell
Copy link
Contributor

What this PR does / why we need it:

We use custom startup, liveness, and readiness probes that exec a bash command. I modified the helm chart to support this ability if people need to use custom probes but if they choose not then the previous definitions still work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

N/A

How Has This Been Tested?

I ran the helm template command before and after and compared the results.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @brianharwell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2021
@rikatz
Copy link
Contributor

rikatz commented May 18, 2021

/ok-to-test
/assign @cpanato

As you're our helm king! :D

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 18, 2021
cpanato
cpanato requested changes May 18, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR
also, bump the chart version in charts/ingress-nginx/Chart.yaml

@cpanato
Copy link
Member

cpanato commented May 18, 2021

/label tide/merge-method-squash

cpanato
cpanato approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2021
@rikatz
Copy link
Contributor

rikatz commented May 18, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 18, 2021
@rikatz
Copy link
Contributor

rikatz commented May 18, 2021

/approve

@rikatz
Copy link
Contributor

rikatz commented May 18, 2021

thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianharwell, cpanato, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2021
@k8s-ci-robot k8s-ci-robot merged commit 293071a into kubernetes:master May 18, 2021
wmfgerrit pushed a commit to wikimedia/operations-puppet that referenced this pull request May 19, 2021
@supertassu
toolforge: Update helm values after chart changes
971c57d 
Fix readiness and liveliness probe definitions in values.yaml for
changes in kubernetes/ingress-nginx#7137

Bug: T264221
Change-Id: Iab44ac2d3da2d3d2a2d97b5232152279536afeaa
gabatwork pushed a commit to gabatwork/ingress-nginx that referenced this pull request May 21, 2021
@gabatwork
squashing
8765d11 
set x-forwarded-scheme like x-forwarded-proto

Add support for custom probes (kubernetes#7137)

* Add support for custom probes

* Fix lint issue with comment

* Bump chart version

* Fix lint issue

Allowing mod-security to be enabled from the controller

formatting

formatting

Allowing mod-security to be enabled from the controller

formatting

formatting

formatting
@hairmare hairmare mentioned this pull request Jun 2, 2021
Merged
6 tasks
carnei-ro pushed a commit to carnei-ro/ingress-nginx that referenced this pull request Jun 7, 2021
@brianharwell @carnei-ro
Add support for custom probes (kubernetes#7137)
61a443a 
* Add support for custom probes

* Fix lint issue with comment

* Bump chart version

* Fix lint issue
@coderabbitai coderabbitai bot mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianharwell @k8s-ci-robot @rikatz @cpanato