-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix session affinity for canaries #7169
Conversation
Welcome @wasker! |
Hi @wasker. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cmluciano @ElvinEfendi Can I get eyes on this PR, please? |
@rikatz Could you help with unblocking this PR, please? |
/ok-to-test |
/retest |
/assign @rikatz |
/kind bug |
/retest |
@rikatz FYI - after rebasing onto the latest from master, SSL test cases do not pass + there's an issue with a build. Is this known? |
Hi @wasker From a Go perspective your PR looks good to me. I've asked for @ElvinEfendi and @moonming to do a review in Lua part. To be honest I'm not sure we should change the default behavior (even broken). I think so, but we need to be really careful warning users about that, like "after this release, it will start working as desired but the desired may not be your desired anymore" :) Let's re-test your tests and I'll keep an eye here, maybe you need to rebase so the latest commits/tests are present in yours as well :) EDIT: Just saw that you already rebased, let me check here |
/retest |
/triage accepted |
@rikatz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
* Drop v1beta1 from ingress nginx Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * Fix intorstr logic in controller Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * fixing admission Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * more intorstr fixing * correct template rendering Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * Fix e2e tests for v1 api Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * Fix gofmt errors * This is finally working...almost there... Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]> * Re-add removed validation of AdmissionReview
Update the DaemonSet namespace references to use the `POD_NAMESPACE` environment variable in the same way that the Deployment does.
Signed-off-by: Jintao Zhang <[email protected]>
* Fix MaxWorkerOpenFiles calculation on high cores nodes * Add e2e test for rlimit_nofile * Fix doc for max-worker-open-files
Signed-off-by: RinkiyaKeDad <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
@wasker: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
If canary ingress is configured, session affinity settings no longer apply, which results in requests within the same session being served by both canary and non-canary endpoints. This affects scenarios when backwards-incompatible changes were deployed to canary, and in inconsistent results being served in general.
Types of changes
The change makes canaries respect session affinity settings by default, as this makes more sense than the current behavior. Nonetheless, there's a way to restore original behavior by adding a special annotation on a non-canary ingress definition, if someone prefers that behavior for some reason.
Which issue/s this PR fixes
Fixes #3717.
How Has This Been Tested?
Used repro steps from the bug to simulate the issue before and after changes.
Checklist: