Add controller.watchIngressWithoutClass config option

[akshitgrover]

Signed-off-by: Akshit Grover [email protected]

What this PR does / why we need it:

Adds controller.watchIngressWithoutClass config option to override the value of --watch-ingress-without-class controller flag

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #7456

How Has This Been Tested?

Helm testing tool
Kubernetes version: 1.22.0

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

@akshitgrover: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @akshitgrover!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @akshitgrover. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[akshitgrover]

I need some help in order to update the documentation with this new config option
I understand there are no helm chart docs , So should we even document this change
cc @rikatz @longwuyuan

[longwuyuan]

Plz point me to the docs link. Thanks, ; Long

…

On Sat, 7 Aug, 2021, 5:14 PM Kubernetes Prow Robot, < ***@***.***> wrote: Welcome @akshitgrover <https://github.com/akshitgrover>! It looks like this is your first PR to kubernetes/ingress-nginx <https://github.com/kubernetes/ingress-nginx> 🎉. Please refer to our pull request process documentation <https://git.k8s.io/community/contributors/guide/pull-requests.md> to help your PR have a smooth ride to approval. You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation <https://go.k8s.io/bot-commands>. You can also check if kubernetes/ingress-nginx has its own contribution guidelines <https://github.com/kubernetes/ingress-nginx/tree/master/CONTRIBUTING.md>. You may want to refer to our testing guide <https://git.k8s.io/community/contributors/devel/sig-testing/testing.md> if you run into trouble with your tests not passing. If you are having difficulty getting your pull request seen, please follow the recommended escalation practices <https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed>. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet <https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md>. We want to make sure your contribution gets all the attention it needs! Thank you, and welcome to Kubernetes. 😃 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7459 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWUK5UKF4KMFMOHEWOTT3UL77ANCNFSM5BXKTN3Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[longwuyuan]

I think maybe comments in code where possible and a link to the migration doc, which is wip. Wdyt Thanks, ; Long

…

On Sat, 7 Aug, 2021, 5:17 PM Yuan, ***@***.***> wrote: Plz point me to the docs link. Thanks, ; Long On Sat, 7 Aug, 2021, 5:14 PM Kubernetes Prow Robot, < ***@***.***> wrote: > Welcome @akshitgrover <https://github.com/akshitgrover>! > > It looks like this is your first PR to kubernetes/ingress-nginx > <https://github.com/kubernetes/ingress-nginx> 🎉. Please refer to our pull > request process documentation > <https://git.k8s.io/community/contributors/guide/pull-requests.md> to > help your PR have a smooth ride to approval. > > You will be prompted by a bot to use commands during the review process. > Do not be afraid to follow the prompts! It is okay to experiment. Here > is the bot commands documentation <https://go.k8s.io/bot-commands>. > > You can also check if kubernetes/ingress-nginx has its own contribution > guidelines > <https://github.com/kubernetes/ingress-nginx/tree/master/CONTRIBUTING.md>. > > > You may want to refer to our testing guide > <https://git.k8s.io/community/contributors/devel/sig-testing/testing.md> > if you run into trouble with your tests not passing. > > If you are having difficulty getting your pull request seen, please > follow the recommended escalation practices > <https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed>. > Also, for tips and tricks in the contribution process you may want to read > the Kubernetes contributor cheat sheet > <https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md>. > We want to make sure your contribution gets all the attention it needs! > > Thank you, and welcome to Kubernetes. 😃 > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#7459 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABGZVWUK5UKF4KMFMOHEWOTT3UL77ANCNFSM5BXKTN3Q> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> > . >

[longwuyuan]

I created a issue to track documenting all values of helm chart including this one #7461 Thanks, ; Long

[akshitgrover]

Thanks for filing the issue @longwuyuan

[rikatz]

/ok-to-test

[rikatz]

/lgtm
/approve
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akshitgrover, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment