Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor documentation cleanup #7826

Merged
merged 35 commits into from
Jan 17, 2022
Merged

Minor documentation cleanup #7826

merged 35 commits into from
Jan 17, 2022

Commits on Jan 12, 2022

  1. clarify link

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1f47a5f View commit details
    Browse the repository at this point in the history

  2. Add section headers

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    47f51af View commit details
    Browse the repository at this point in the history

  3. console blocks

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    802e279 View commit details
    Browse the repository at this point in the history

  4. grpc example json was not valid

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    027d7ca View commit details
    Browse the repository at this point in the history

  5. multi-tls update text 

    The preceding point 1 related to https://github.com/kubernetes-retired/contrib/blob/4f2cb51ef82b4dddb625f6053ad132c1faf07aa1/ingress/controllers/nginx/examples/ingress.yaml
and the deployments referenced in https://github.com/kubernetes-retired/contrib/blob/4f2cb51ef82b4dddb625f6053ad132c1faf07aa1/ingress/controllers/nginx/examples/README.md

They are not relevant to the current instructions.
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    3267048 View commit details
    Browse the repository at this point in the history

  6. add whitespace around parens

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    4bf63aa View commit details
    Browse the repository at this point in the history

  7. grammar 

    setup would be a proper noun, but it is not the intended concept, which is a state
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    10e1baa View commit details
    Browse the repository at this point in the history

  8. grammar 

    * is-only
* via
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    6ef4478 View commit details
    Browse the repository at this point in the history

  9. Use bullets for choices

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    2d6e7a7 View commit details
    Browse the repository at this point in the history

  10. ingress-controller 

    nginx is a distinct brand.

generally this repo talks about ingress-controller, although it is quite inconsistent about how...
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b9c9b97 View commit details
    Browse the repository at this point in the history

  11. drop stray paren

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    766705d View commit details
    Browse the repository at this point in the history

  12. OAuth is a brand and needs an article here 

    also GitHub is a brand
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    8927c1b View commit details
    Browse the repository at this point in the history

  13. Indent text under numbered lists

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    3e0cc91 View commit details
    Browse the repository at this point in the history

  14. use e.g.

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    cd578eb View commit details
    Browse the repository at this point in the history

  15. Document that customer header config maps changes do not trigger updates 

    This should be removed if
kubernetes#5238
is fixed.
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    00dc586 View commit details
    Browse the repository at this point in the history

  16. article

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    cdac21c View commit details
    Browse the repository at this point in the history

  17. period

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    bbaec16 View commit details
    Browse the repository at this point in the history

  18. infinitive verb + period

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    c46a2bf View commit details
    Browse the repository at this point in the history

  19. clarify that the gRPC server is responsible for listening for TCP tra… 

    …ffic and not some other part of the backend application
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    abbd832 View commit details
    Browse the repository at this point in the history

  20. avoid using ; and reword

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    82af094 View commit details
    Browse the repository at this point in the history

  21. whitespace

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    f5512de View commit details
    Browse the repository at this point in the history

  22. brand: gRPC

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0158859 View commit details
    Browse the repository at this point in the history

  23. only-does is the right form 

    `for` adds nothing here
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    77c4185 View commit details
    Browse the repository at this point in the history

  24. spelling: GitHub

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    56b360a View commit details
    Browse the repository at this point in the history

  25. punctuation 

    `;` is generally not the right punctuation...
    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    7e66194 View commit details
    Browse the repository at this point in the history

  26. drop stray to

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    e2c3d94 View commit details
    Browse the repository at this point in the history

  27. sentence

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b995864 View commit details
    Browse the repository at this point in the history

  28. backticks

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    cf6da8e View commit details
    Browse the repository at this point in the history

  29. fix link

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1c528d3 View commit details
    Browse the repository at this point in the history

  30. Improve readability of compare/vs

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    50444a9 View commit details
    Browse the repository at this point in the history

  31. Renumber list

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    ec65187 View commit details
    Browse the repository at this point in the history

  32. punctuation

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    4e49830 View commit details
    Browse the repository at this point in the history

  33. Favor Ingress-NGINX and Ingress NGINX

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    d5a748f View commit details
    Browse the repository at this point in the history

  34. Simplify custom header restart text

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    e53694a View commit details
    Browse the repository at this point in the history

  35. Undo typo damage

    @jsoref
    jsoref committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    edd9a3b View commit details
    Browse the repository at this point in the history