-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use functional options to reduce number of methods creating an EchoDeployment #8199
use functional options to reduce number of methods creating an EchoDeployment #8199
Conversation
Hi @dmathieu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature Thanks for simplifying those tests. |
This is a great change! Thanks! |
@rikatz why are we holding? /cancel hold |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmathieu, iamNoah1, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR is a refactoring of the
NewEchoDeployment
test helper. We currently require several methods which are becoming quite long in their name, this so we can specify some arguments or others.The refactor relies on functional attributes instead to allow specifying only the attributes we need while retaining only one method.
Before:
After:
I need this as part of my sidecar modules work. With this change in place, I will be able to add a
WithDeploymentModules
option which will allow configuring modules for a deployment.Types of changes
This is a refactoring of test helpers.
How Has This Been Tested?
This is being fully tested through unit and e2e tests.
Checklist: