Update controller-service.yaml to fix ipFamilies

[MikeK184]

See Issue: #8328

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: MikeK184 / name: Mike (17e03f6)

[k8s-ci-robot]

Welcome @MikeK184!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @MikeK184. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MikeK184
To complete the pull request process, please assign cpanato after the PR has been reviewed.
You can assign the PR to them by writing /assign @cpanato in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cpanato]

@MikeK184 can you please sign the CLA? thanks!

[MikeK184]

@MikeK184 can you please sign the CLA? thanks!

Just signed it a minute ago :).

[cpanato]

/ok-to-test
/triage accepted
/priority important-soon

[cpanato]

can you bump the chart version as well? thanks for this PR

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: MikeK184 / name: Mike (17e03f6, 4e194e5)

[MikeK184]

can you bump the chart version as well? thanks for this PR

Not sure if that's all that needed to be changed.

[longwuyuan]

@MikeK184 You need to run helmdocs to generate a new README.md for the chart. Its documented in RELEASE.md

@afirth just curious, was it you who made some changes, to improve/solve-problem related to ipfamilies.

[afirth]

@longwuyuan

@afirth just curious, was it you who made some changes, to improve/solve-problem related to ipfamilies.

no, #8162 and #8099 just make the static manifests' helm template respect the semver compare - it used to just pretend it was 1.20 all the time

[longwuyuan]

Someone needs to verify if the change to 1.21 is valid because K8s v1.21 is where ipfamilies is enabled by default. But This screenshot shows that ipfamilies is/was available as a feature in K8s v1.20 as well. Or this page on Kubernetes.io is showing wrong information and needs a change

https://kubernetes.io/docs/concepts/services-networking/dual-stack/

If a user of K8s v1.20 uses ipfamilies and does not get it out of the box while using the project's helm chart, because of this change, then we are breaking a currently functional feature for K8s v1.20.

But I could be wrong completely so maybe someone needs to double-check.

[MikeK184]

This is what the Feature Gates docs says:

Not sure how to interpret this tho, so the feature gate for dual stack in "beta version" is enabled by default with version 1.21. But the "alpha version" can be used starting from 1.15 to 1.20;

This somewhat speaks against what the docs say with version 1.20.

[afirth]

alpha gates are not enabled by default, and not available on most cloud providers. IMO safe to assume this PR behaviour is what 99.99% of our users want. The others can use the static manifests, fork the chart, or use the helm kustomize post hooks. I think as a rule, we should never try to install alpha K8s features by default. If a user wants it on, another PR can introduce an enableDualStack or whatever flag that we || with this

[longwuyuan]

I am also unsure how to interpret that. What I am sure about is that there was someone paying lot of attention to ipfamilies ans using K8s v1.19. If having v1.20 in semver-compare is not breaking anything, then I don’t want to change it so that we can avoid the risk of someone using ipfamilies on v1.20. If that is what that feature-gate doc implies as use of Alpha. After K8s v1.24 is out, we can state that we support only K8s v.121 and above only. Because I think some of the Cloud-Provider clusters are still on v1.20 for one or the other reason. Thanks, ; Long Wu Yuan

…

On 11-Mar-2022, at 8:37 PM, Mike ***@***.***> wrote: This is what the Feature Gates <https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/> docs says: <https://user-images.githubusercontent.com/56921065/157893240-c6895fec-a284-4280-a1bf-20465b882c8e.png> Not sure how to interpret this tho, so the feature gate for dual stack in "beta version" is enabled by default with version 1.21. But the "alpha version" can be used starting from 1.15 to 1.20? — Reply to this email directly, view it on GitHub <#8329 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWQ3GOOKGDG5RUAGUG3U7NOTTANCNFSM5QPTXJQQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.

[MikeK184]

I've quickly made an issue for that to confirm if its just a typo: kubernetes/website#32212

[strongjz]

I included this fix in the 1.1.3 release

https://github.com/kubernetes/ingress-nginx/pull/8411/files#diff-55ee4c2a2aed7c0b4796c6e37ac3e10e689443dcd20b34f83f7e02030e315759R40

/close

[strongjz]

I included this fix in the 1.1.3 release

https://github.com/kubernetes/ingress-nginx/pull/8411/files#diff-55ee4c2a2aed7c0b4796c6e37ac3e10e689443dcd20b34f83f7e02030e315759R40

/close

[k8s-ci-robot]

@strongjz: Closed this PR.

In response to this:

I included this fix in the 1.1.3 release

https://github.com/kubernetes/ingress-nginx/pull/8411/files#diff-55ee4c2a2aed7c0b4796c6e37ac3e10e689443dcd20b34f83f7e02030e315759R40

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@strongjz: Closed this PR.

In response to this:

I included this fix in the 1.1.3 release

https://github.com/kubernetes/ingress-nginx/pull/8411/files#diff-55ee4c2a2aed7c0b4796c6e37ac3e10e689443dcd20b34f83f7e02030e315759R40

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.