Add CAP_SYS_CHROOT to DS/PSP when needed

[mac-chaffee]

What this PR does / why we need it:

When using chroot mode (--set controller.image.chroot=true) alongside podsecuritypolicies and a daemonset (--set podSecurityPolicy.enabled=true --set controller.kind=DaemonSet), it doesn't work since the DS/PSP are missing the SYS_CHROOT capability. This PR fixes that.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

Fixes #8517

How Has This Been Tested?

helm template ./ingress-nginx --set podSecurityPolicy.enabled=true --set controller.image.chroot=true --set controller.kind=DaemonSet | grep -A 55 DaemonSet

helm template ./ingress-nginx --set podSecurityPolicy.enabled=true --set controller.image.chroot=true --set controller.kind=DaemonSet | grep -A 25 PodSecurityPolicy

Checklist:

• [n/a] My change requires a change to the documentation.
• [n/a] I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• [n/a] I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

@mac-chaffee: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @mac-chaffee. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

/ok-to-test

[rikatz]

/lgtm
/approve
Good catch! :D Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mac-chaffee, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[viq]

Any idea when a new helm release with this in will be available?

[mac-chaffee]

Guess I was supposed to bump the chart version: https://github.com/kubernetes/ingress-nginx/runs/6453045684?check_suite_focus=true

[cpanato]

that is correct, the chart was not bumped in this pr, so need a chart bump and update the changelog
are you willing to open a pr to get this fixed?