Optional podman support for running tests locally

[kirs]

Some environments don't allow Docker for Desktop for licensing concerns and use Podman instead.

This is an attempt to allow some optional support for Podman, at least for running local tests.

You can try it with RUNTIME=podman build/run-in-docker.sh test/test-lua.sh.

I spoke to @ElvinEfendi mentioned that the team would be open to swapping docker for local development with podman completely, I might take an attempt at some point - but right now I believe this smaller diff can unblock us faster to run tests locally.

[k8s-ci-robot]

@kirs: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @kirs. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kirs]

This dance is needed because /var/folders/<some-tmp-name> created on Mac is not available on the VM managed by Podman. It has to be something in the local dir of the project.

[longwuyuan]

@kirs thank you for this. Its an awesome help.

But is this agnostic to OS ? Does it currently only work on M1 Mac or Intel Mac ? Does it need any change to be used on Linux lpatop/dekstop ?

[rikatz]

besides @longwuyuan question (which I agree) it is great! Thanks for that! Let me know if you need someone to test this on a Mac Intel :D

[kirs]

@longwuyuan there's nothing here that would be M1 or Intel specific. As long as Podman is compatible with both this should just work. Same for Linux, I expect it to work as is.

@rikatz I'd appreciate if you could help to test this on Mac Intel just in case 🙏

[longwuyuan]

@kirs thanks for updating. If you did test on linux, please confirm. Sorry for persisting because there are some nuances experienced earlier relating to running tests in VMs

[kirs]

Tested on Linux:

$ git status
On branch optional-podman-support
Your branch is up to date with 'origin/optional-podman-support'.

nothing to commit, working tree clean
$ uname -a
Linux kirs-k8s-devbox 5.10.0-19-cloud-amd64 #1 SMP Debian 5.10.149-2 (2022-10-21) x86_64 GNU/Linux
$ RUNTIME=podman build/run-in-docker.sh test/test-lua.sh
..printing env & other vars to stdout
...
+ set -o errexit
+ set -o nounset
+ set -o pipefail
+ BUSTED_ARGS='-v --pattern=_test'
+ resty -I ./rootfs/etc/nginx/lua --shdict 'configuration_data 5M' --shdict 'certificate_data 16M' --shdict 'certificate_servers 1M' --shdict 'ocsp_response_cache 1M' --shdict 'balancer_ewma 1M' --shdict 'balancer_ewma_last_touched_at 1M' --shdict 'balancer_ewma_locks 512k' --shdict 'global_throttle_cache 5M' ./rootfs/etc/nginx/lua/test/run.lua -v --pattern=_test ./rootfs/etc/nginx/lua/test/ ./rootfs/etc/nginx/lua/plugins/hello_world/test
●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●●
196 successes / 0 failures / 0 errors / 0 pending : 0.209227 seconds

[longwuyuan]

@kirs thank you very much for the test.
/ok-to-test

[longwuyuan]

@kirs CI failing. I can try to answer question if any. PTAL

[tao12345666333]

Thanks, this idea LGTM

One question, do we need to cover this scenario in CI? For example, test it with Podman?

[tao12345666333]

I keep an eye on some of Podman's features and documentation, but I don't really use it, especially on macOS

[longwuyuan]

Original idea in this PR is not for CI. Just for local use. So ideally, CI should ignore this now.

In future, if many other projects are happy for several months with podman, then its ok to explore CI with podman.

So I think currently just need to adjust CI so that it does not fail on podman. Not even sure if the latest CI failure is because of this change.

[kirs]

Had to rewrite this because of that extra flag for docker below.

[ElvinEfendi]

I think you could make this part of the args initialization above. Maybe you wanted to keep the order of args unchanged? I'd think order does not matter.

[kirs]

Thanks for pointing this out, updated!

[ElvinEfendi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, kirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment