-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate ingress path fields #9309
Conversation
@rikatz: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6cf873b
to
c265e3e
Compare
2c53bcd
to
12ae609
Compare
12ae609
to
7f40562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Validate characters in path fields * Add e2e tests for path validation * Fix review comments
@rikatz This seems to have broken our ingress resources. This was working before this change: spec:
ingressClassName: internal-ingress
rules:
- host: foo.com
http:
paths:
- backend:
service:
name: foo
port:
number: 8080
path: /foo(/|$)(.*)
pathType: Prefix What would be a 'valid' path in above after this change? |
To add to this... Would it not be better to use |
What this PR does / why we need it:
Adds validation on "path" fields in Ingress objects
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Added additional unit and e2e tests
Does my pull request need a release note?