resolved ginkgo deprecation message

[SaumyaBhushan]

fix ginkgo deprecations

What this PR does / why we need it:

change the args with the latest args in v2 of ginkgo . #9337

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

#9337

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

• CLI change
• API change
• UI change
• configuration schema change
• behavioral change
• change in non-functional attributes such as efficiency or availability, availability of a new platform
• a warning about a deprecation
• fix of a previous Known Issue
• fix of a vulnerability (CVE)

No release notes are required for changes to the following:

• Tests
• Build infrastructure
• Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

PLACE RELEASE NOTES HERE

[k8s-ci-robot]

Hi @SaumyaBhushan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@tao12345666333 , you can see that even this contributor is getting new go.mod & go.sum because of slim-sprig and pprof. Its not only me. Please lets meet again and look at the 2 dependencies on a Zoom meeting, by creating an environment in a VM with go v1.19.2 .

@SaumyaBhushan , what is the go version in your local environment ? Also do you have ginkgo installed locally ? If yes, what is the version of ginkgo on your local environment ?

cc @rikatz

[longwuyuan]

/ok-to-test

[SaumyaBhushan]

@tao12345666333 It is go1.19.3 and I haven't installed ginkgo locally

[longwuyuan]

/triage accepted
/priority important-soon
/area stabilization

[rikatz]

why is this commented out? https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed--slowspecthreshold this is still supported right?

[rikatz]

/lgtm
/approve
Thanks

@longwuyuan @SaumyaBhushan let's just keep an eye if this starts flaking the tests :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, SaumyaBhushan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[longwuyuan]

@rikatz , I have been talking to Jintao but we did not move ahead on the topic of go.mod+go.sum changes. Now here I see this has already merged so just hoping to get an ack from you on the new indirectly dependency modules added to go.mod in this PR.

@SaumyaBhushan although this has merged, I too had that same question that Ricardo asked but I was waiting to ask it after we closed the go.mod changes topic. Now, can you please help me clearly understand why you commented out "-slow-spec-threshold=${SLOW_E2E_THRESHOLD}" . I have not checked the docs or the link that Ricardo posted yet. I hope to check myself after you comment on this.

[longwuyuan]

@SaumyaBhushan, ignore my prrvious comment. I saw just now that the feature deprecation message is printed right there, in the very example output from a live test, that I myself posted in the issue description ;

--ginkgo.slow-spec-threshold is deprecated 

all good on that topic now.

@rikatz just discovered that that flag is deprecated in ginkgo v2.5.0 https://github.com/onsi/ginkgo/releases and we are now on v2.5.1

[SaumyaBhushan]

@SaumyaBhushan, ignore my prrvious comment. I saw just now that the feature deprecation message is printed right there, in the very example output from a live test, that I myself posted in the issue description ;

--ginkgo.slow-spec-threshold is deprecated 

all good on that topic now.

@rikatz just discovered that that flag is deprecated in ginkgo v2.5.0 https://github.com/onsi/ginkgo/releases and we are now on v2.5.1

Right @longwuyuan