-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[user-guide configmap] fix doc for global-auth-snippet #9372
Conversation
@tomislater: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @tomislater! |
Hi @tomislater. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tomislater , thanks for the contribution
|
The description has been updated. |
Thanks @tomislater . I think we can merge this now.
We could easily go ahead and merge this simple one liner change but I hope you understand what I am trying to express. Waiting to know your thoughts. |
Hmm, but it is just a change in the documentation. Why would I need to run tests 🤔I don't change any logic here. I observed that this sentence was wrong and I wanted to fix it. 8cc9afe - looks that here someone 4 years ago added this to the documentation and just inserted annotation from the previous block? And forgot to change it? |
@tomislater understood. Thank you. /ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, tomislater The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I wanted to add global
auth-snippet
, so I started reading the documentation and then I encountered the wrong sentence. It fixes the wrong sentence.Types of changes
Which issue/s this PR fixes
N/A
How Has This Been Tested?
N/A
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook