Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0

[SaumyaBhushan]

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

• CLI change
• API change
• UI change
• configuration schema change
• behavioral change
• change in non-functional attributes such as efficiency or availability, availability of a new platform
• a warning about a deprecation
• fix of a previous Known Issue
• fix of a vulnerability (CVE)

No release notes are required for changes to the following:

• Tests
• Build infrastructure
• Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

PLACE RELEASE NOTES HERE

[k8s-ci-robot]

@SaumyaBhushan: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @SaumyaBhushan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@SaumyaBhushan Please check the reference PR I mentioned earlier for the file that need change. Meaning changelog does not need to be edited in this PR. It will happen at the time of the release. So revert changelog.md .

[longwuyuan]

Also don't change go,mod as the dependabot PR will do that. I understand this is not right but until we fix dependabot to and our code, and until Ricardo and Jintao have a plan, lets just follow this crude 2-PR process because it helps avoid more complications. We will have to keep doing these PRs like 2PRs for bumping ginkgo until we find a way to sanely do it in a single PR while using the advantage of dependabot initiating this, on upstream ginkgo releases. @SaumyaBhushan

cc @rikatz @tao12345666333 @strongjz

[SaumyaBhushan]

Also don't change go,mod as the dependabot PR will do that. I understand this is not right but until we fix dependabot to and our code, and until Ricardo and Jintao have a plan, lets just follow this crude 2-PR process because it helps avoid more complications. We will have to keep doing these PRs like 2PRs for bumping ginkgo until we find a way to sanely do it in a single PR while using the advantage of dependabot initiating this, on upstream ginkgo releases. @SaumyaBhushan

cc @rikatz @tao12345666333 @strongjz

Sure @longwuyuan . Thanks

[longwuyuan]

The bot has an option to squash commits but personally I prefer to squash locally so that the PR is clean to look review etc. You could consider squashing your multiple commit locally. Thanks, ; Long

…

On 12/14/22 11:38, Saumya wrote: Also don't change go,mod as the dependabot PR will do that. I understand this is not right but until we fix dependabot to and our code, and until Ricardo and Jintao have a plan, lets just follow this crude 2-PR process because it helps avoid more complications. We will have to keep doing these PRs like 2PRs for bumping ginkgo until we find a way to sanely do it in a single PR while using the advantage of dependabot initiating this, on upstream ginkgo releases. @SaumyaBhushan <https://github.com/SaumyaBhushan> cc @rikatz <https://github.com/rikatz> @tao12345666333 <https://github.com/tao12345666333> @strongjz <https://github.com/strongjz> Sure @longwuyuan <https://github.com/longwuyuan> . Thanks — Reply to this email directly, view it on GitHub <#9408 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWUH425YRJK4MUSQGT3WNFP5NANCNFSM6AAAAAAS6APFKY>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[SaumyaBhushan]

The bot has an option to squash commits but personally I prefer to squash locally so that the PR is clean to look review etc. You could consider squashing your multiple commit locally. Thanks, ; Long
…
On 12/14/22 11:38, Saumya wrote: Also don't change go,mod as the dependabot PR will do that. I understand this is not right but until we fix dependabot to and our code, and until Ricardo and Jintao have a plan, lets just follow this crude 2-PR process because it helps avoid more complications. We will have to keep doing these PRs like 2PRs for bumping ginkgo until we find a way to sanely do it in a single PR while using the advantage of dependabot initiating this, on upstream ginkgo releases. @SaumyaBhushan https://github.com/SaumyaBhushan cc @rikatz https://github.com/rikatz @tao12345666333 https://github.com/tao12345666333 @strongjz https://github.com/strongjz Sure @longwuyuan https://github.com/longwuyuan . Thanks — Reply to this email directly, view it on GitHub <#9408 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGZVWUH425YRJK4MUSQGT3WNFP5NANCNFSM6AAAAAAS6APFKY. You are receiving this because you were mentioned.Message ID: @.***>

Done Thanks @longwuyuan for the suggestion

[longwuyuan]

thanks.
/ok-to-test

@tao12345666333 when you lgtm the dependabot PR to bump ginkgo, please look at this PR as well and consider merging this PR also at the same time.

[longwuyuan]

/lgtm

@tao12345666333 @rikatz @strongjz , seeking approval on tihis asap

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, SaumyaBhushan, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment