Automated Release controller-v1.5.2 #9455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
needs-priority
approved
Signed-off-by: James Strong <[email protected]>
|
/kind feature |
k8s-ci-robot
added
kind/feature
|
/retest |
strongjz
requested review from
rikatz and
tao12345666333
and removed request for
ElvinEfendi and
ChiefAlexander
strongjz
commented
Dec 28, 2022
| @@ -90,21 +90,6 @@ rules: | |||
| - get | |||
| - list | |||
| - watch | |||
| - apiGroups: | |||
There was a problem hiding this comment.
@tao12345666333 was this removed purposely?
There was a problem hiding this comment.
yes! we don't need the configmap for lock
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jaehnri
pushed a commit
to jaehnri/ingress-nginx
that referenced
this pull request
Jan 2, 2023
Signed-off-by: James Strong <[email protected]> Signed-off-by: James Strong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Strong [email protected]
What this PR does / why we need it:
Types of changes
Release 1.5.2
Which issue/s this PR fixes
fixes #
How Has This Been Tested?
Checklist:
Does my pull request need a release note?
Any user-visible or operator-visible change qualifies for a release note. This could be a:
No release notes are required for changes to the following:
For more tips on writing good release notes, check out the Release Notes Handbook