-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix print-e2e-suite #9536
Fix print-e2e-suite #9536
Conversation
Before: ``` $ make print-e2e-suite Reached DIND check ELSE block, inside run-in-docker.sh Compiled e2e.test Reached DIND check ELSE block, inside run-in-docker.sh + set -o errexit + set -o nounset + set -o pipefail +++ dirname hack/print-e2e-suite.sh ++ cd hack/.. ++ pwd -P + DIR=/go/src/k8s.io/ingress-nginx + /go/src/k8s.io/ingress-nginx/test/e2e/e2e.test -ginkgo.noColor -ginkgo.dryRun + sed 's|/go/src/k8s.io/ingress-nginx/|File: |g' + sed s/•//g + + head -n-3tail -n+5 You're using deprecated Ginkgo functionality: ============================================= --ginkgo.dryRun is deprecated, use --ginkgo.dry-run instead Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags --ginkgo.noColor is deprecated, use --ginkgo.no-color instead Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#changed-command-line-flags To silence deprecations that can be silenced set the following environment variable: ACK_GINKGO_DEPRECATIONS=2.6.1 Will run 423 of 423 specs ``` After: ``` $ make print-e2e-suite Reached DIND check ELSE block, inside run-in-docker.sh Compiled e2e.test Reached DIND check ELSE block, inside run-in-docker.sh Will run 423 of 423 specs ------------------------------ [Annotations] service-upstream when using the default value (false) and enabling in the annotations should use the Service Cluster IP and Port File: test/e2e/annotations/serviceupstream.go:41 [0.000 seconds] ------------------------------ [...] ``` Signed-off-by: Hervé Werner <[email protected]>
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @dud225. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
-ginkgo.noColor \ | ||
-ginkgo.dryRun | sed "s|$DIR/|File: |g" | sed 's/•//g' | tail -n+5 | head -n-3 | ||
--ginkgo.no-color \ | ||
--ginkgo.v \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC yes since it wouldn't display the list of the test files otherwise. See my message above where it only prints "Will run 423 of 423 specs"
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dud225, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before:
After: