-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert path validation #9585
Revert path validation #9585
Conversation
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This should be all the merge/commits between head on main and helm 4.4.2 tag. Please let us know if anything is missing. |
/retest |
There have conflicts to be resolved. |
046bbf4
to
c5d49eb
Compare
/retest |
11c02d6
to
dea3a9a
Compare
a8e6552
to
dea3a9a
Compare
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem with anything except changelog/Changelog-1.5.2.md.
We can fix it in a follow-up PR.
I will add LGTM label,
Once you want to merge, you can remove the hold
/lgtm
/hold
And I want to add a squash label. We won't be cherry-picking or otherwise doing anything from the current commits. /label tide/merge-method-squash |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: strongjz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Commit messages seem to be the only problem. |
What this PR does / why we need it:
reverts path type validation changes
Types of changes
Which issue/s this PR fixes
fixes #9569
How Has This Been Tested?
Checklist: