Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanning port 10247 lead to tcp connection 502 error #9815

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

lijiecm
Copy link
Contributor

@lijiecm lijiecm commented Mar 31, 2023

If you have a safe process to scan local port 10247, Ingress nginx will clean up your backend endpoints. At this time, While you change your http project, Ingress nginx will be reloaded and your tcp connection will have a 502 error.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added the area/lua Issues or PRs related to lua code label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @lijiecm!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @lijiecm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
@strongjz
Copy link
Member

strongjz commented Apr 4, 2023

Can you clarify what you mean by scanning a port and how it relates to a 502 when backends are not there?

@lijiecm
Copy link
Contributor Author

lijiecm commented Apr 6, 2023

Can you clarify what you mean by scanning a port and how it relates to a 502 when backends are not there?

for example ,you have a process used tcp-services, when you update your pod ,ingress controller will be update your tcp backends, but if you requests ingress http://127.0.0.1:10247, lua will use strings "GET / HTTP/1.1" to clean your tcp backends , this time if you have a http service update ,ingress nginx will be reload, all of your tcp service will be 502 error.

image

image

image

@rikatz
Copy link
Contributor

rikatz commented May 1, 2023

makes sense.

@lijiecm can you sign the CLA please?

Thanks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 6, 2023
@lijiecm
Copy link
Contributor Author

lijiecm commented May 6, 2023

makes sense.

@lijiecm can you sign the CLA please?

Thanks

Done

Thanks

@rikatz
Copy link
Contributor

rikatz commented Jun 11, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2023
@rikatz
Copy link
Contributor

rikatz commented Jun 11, 2023

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2023
@rikatz
Copy link
Contributor

rikatz commented Jun 11, 2023

@lijiecm there is a fix on lua code, can you take a look please?

Thanks!!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@lijiecm
Copy link
Contributor Author

lijiecm commented Jun 14, 2023

@rikatz done, It looks like the checks passed

@rikatz
Copy link
Contributor

rikatz commented Jul 16, 2023

/lgtm
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijiecm, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0cd1f16 into kubernetes:main Jul 16, 2023
@strongjz
Copy link
Member

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

@strongjz: new pull request created: #10222

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/lua Issues or PRs related to lua code cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants